Repository navigation
refactor(offline): centralize native tool setup - #3096
Merged
Merged
Conversation
- Keep storage-to-tool identity in the offline tool package. - Share settings persistence, tool initialization, and storage admission across handlers. - Preserve endpoint payloads and unsupported-storage diagnostics with focused tests. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
nostalume
marked this pull request as ready for review
September 19, 2026 11:38
9 of 11 tasks
jyxjjj
approved these changes
Sep 19, 2026
pikachuren
reviewed
Sep 21, 2026
pikachuren
left a comment
pikachuren
left a comment
Collaborator
There was a problem hiding this comment.
🙏 感谢 @nostalume 提交！
🤖 AI 自动审核声明：本评审报告由 AI 自动生成，当前使用 Claude Opus 5 模型进行分析。
🎯 结论
✅ Approve — 代码质量良好，建议合并
📖 概要
refactor(offline): centralize native tool setup
📊 评审结果
改动合理，无重大问题发现。代码逻辑清晰，符合项目规范。
🎯 结论：✅ Approve — 建议合并
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Centralize offline-download storage-to-native-tool selection in
internal/offline_download/tool.Let the HTTP handler delegate save-path assignment, tool lookup, and tool initialization to the tool package instead of importing every concrete tool driver.
Preserve the existing endpoint schema, validation, task status, tool names, and storage compatibility while removing duplicated dispatch code.
Add behavior-focused tests for supported storage mappings, unsupported storage errors, and handler request validation.
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Testing / 测试
Windows:
go test ./internal/offline_download/tool ./server/handles -count=1Windows:
go vet ./internal/offline_download/tool ./server/handlesLinux/WSL (earlier verification of the same commit):
go test -race ./internal/offline_download/tool ./server/handles -count=3Final diff:
git diff --check FETCH_HEAD...HEADgo test ./...Manual test / 手动测试:
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。