Repository navigation
fix(ftp): refuse MKD of a path that already exists - #3290
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
MKD on an existing directory replied 257 because fs.MakeDir treats an existing directory as success. Check the path first and fail, so MKD gets 550 like other FTP servers. SITE MKDIR goes through MkdirAll, which keeps accepting an existing directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
MKD of a folder that is already there answers as if it made it:
FTP clients use the 550 to tell "made it" from "was already there" (mirror and sync tools create folders this way).
fs.MakeDirtreats an existing folder as success, so the FTP driver passed that through.ftp.Mkdirnow looks the path up first and fails if anything is there, so MKD gets 550. SITE MKDIR goes throughAferoAdapter.MkdirAll, which keeps accepting an existing folder, likeos.MkdirAll. MKD over a file already gave 550 and still does./ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Testing / 测试
go test ./...(onlypkg/aria2/rpcfails: it needs an aria2 daemon on :6800, same on main)Manual test / 手动测试:
Built main and this branch, local storage at
/, FTP on, Python ftplib: on main a secondMKD newdiranswers 257; here it answers 550 "file or directory already exists". A new folder and nested folders still give 257, and SITE MKDIR on an existing folder still gives 250.New
TestMkdirRefusesExistingPath(in-memory DB + Local storage); against main's Mkdir it fails on the existing folder.go test ./server/... ./internal/...passes.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Tests / 测试
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。