Repository navigation
Conversation
Record the per round train and validation metric history and expose it as a learning_curves table and a plot_learning_curves() figure, so overfitting is easy to spot. Adds tests and a section in the model explainability tutorial. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXEaoRCwBuFiLDca7M47FT Signed-off-by: Engr. Muhammad Fahad <muhammadfahadx2.0@gmail.com>
fahad-ee
force-pushed
the
feat/947-learning-curves
branch
from
November 9, 2026 07:10
670e013 to
9d2a1c7
Compare
JanMaartenvanDoorn
requested changes
Nov 13, 2026
JanMaartenvanDoorn
left a comment
Member
There was a problem hiding this comment.
Code looks good, could you please target Main instead of OpenSTEF:release/v4.0.0 ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #947. Covers XGBoost and GBLinear; LightGBM will follow in a separate PR.
What this adds
LearningCurveMixinwith alearning_curvestable (train and validation metric per boosting round) andplot_learning_curves().LearningCurvePlotter: a Plotly chart of the two curves with the best validation round marked.XGBoostForecasterandGBLinearForecaster.Design notes
mean_pinball_lossin OpenSTEF).Why LightGBM is not included
MultiQuantileRegressor.fit()acceptseval_setbut does not pass it to the base learners, soevals_result_is empty after fitting. I plan a separate PR for that fix, then LightGBM curves. Happy to change the plan if you prefer otherwise.Testing
test_normalize_tracking_uri[absolute-posix]). It is unrelated to this change.