You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the road marking class the enum RoadMarking_Classification_Color is missing the index 4. This is very troublesome for the test procedures since a random number from 0 - 7 does not cover all the cases and the range is wrong. It would be very nice if someone could take a look at this.
This seems to be a hold-over from the initial OSI commit, which already did not contain a color with index 4. We should likely fix this at some time; for OSI 3.x we can only fix this by adding a new color with index 4 (maybe a relevant color is still missing?), renumbering would only be possible with 4.x.
@LudwigFriedmannBMW As Pierre points out, a re-sort leads to a major version change (4.x). Adding a new color could close the gap (3.1.x). Should we disallow missing elements in enums (e.g. by a test)? This would be different from numbering of the attributes in the messages.
Activity
pmai commentedon May 22, 2018
This seems to be a hold-over from the initial OSI commit, which already did not contain a color with index 4. We should likely fix this at some time; for OSI 3.x we can only fix this by adding a new color with index 4 (maybe a relevant color is still missing?), renumbering would only be possible with 4.x.
Can someone check this with relevant users?
carsten-kuebler commentedon Aug 20, 2018
@LudwigFriedmannBMW As Pierre points out, a re-sort leads to a major version change (4.x). Adding a new color could close the gap (3.1.x). Should we disallow missing elements in enums (e.g. by a test)? This would be different from numbering of the attributes in the messages.
yash-shah-asam commentedon Apr 24, 2025
@thomassedlmayer Could you please take a look at this in the Sensor modeling group?
thomassedlmayer commentedon Apr 30, 2025
Sensor Modeling Meeting (2025-04-30): We could add the color black? We at least found some examples with black road markings: