Skip to content

test(chain): stabilize governed HTTP pacing assertion - #2986

Merged
branarakic merged 1 commit into
testnet-canaryfrom
codex/fix-rpc-pacing-ci-20261003
Oct 3, 2026
Merged

branarakic merged 1 commit into
testnet-canaryfrom
codex/fix-rpc-pacing-ci-20261003

Conversation

@branarakic

@branarakic branarakic commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stabilize the governed HTTP pacing regression test without changing production RPC admission, rate limits, transport code, or CI policy.

The testnet-canary run at 384f752582e91ba3e8d44baa1fd0f29bff397578 failed in Tornado: chain [3/3]: the pacing test polled for exactly one HTTP request during a real-time 50 ms token window, but observed two after the window elapsed. The coverage merge and final CI gate consequently failed.

Changes

  • Use the existing governor clock injection to hold token refill time while observing the first completed real HTTP request.
  • Advance refill time explicitly before awaiting the second request; leave HTTP and timer scheduling real.
  • Assert the two physical HTTP requests remain separate, single-entry dispatches.
  • Own both request promises and cancel/drain them on teardown, including failed assertions.

Validation

  • Reproduced the original failure with a temporary 75 ms observer delay and unchanged production code.
  • The fixed test passed 20/20 isolated repetitions with that same delay.
  • A temporary admission-bypass mutation correctly made the test fail.
  • 73/73 neighboring governor, admission, registry-admission, and failover tests passed.
  • pnpm lint passed; disabled-test audit reports no additions.
  • git diff --check passed.
  • GitHub CI and EVM integration completed successfully at 891604fe58a326248d6f6d842135f83714f280bc, including chain [3/3], merged package coverage, and the final CI gate.
  • All registered checks are complete: 40 success, 11 expected policy-selected skips. Automated review found no issues; GitHub reports MERGEABLE / CLEAN.
  • Canonical covered CI shard DKG_CI_COVERAGE=1 node scripts/ci/run-vitest-lanes.mjs --job tornado-core --row 3 passed: 57/57 files, 1072 passed, 3 existing skips, at commit 891604fe58a326248d6f6d842135f83714f280bc.

All reproduction/mutation changes have been removed. The running mainnet node and its checkout are untouched. This removes a CI-test race; it is not broader release certification.

@otReviewAgent otReviewAgent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Agent completed this review and found no issues.

@branarakic
branarakic merged commit b5bbcc9 into testnet-canary Oct 3, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants