Skip to content

Rename PRQL - SQL Output panel to SQL Preview #46

Closed

Description

@RandomFractals

and use standard vscode $(open-preview) icon with SQL Preview webview panel title to display generated SQL code.

This would ensure we are using standard vscode icon and nomenclature for the Preview panel.

The corresponding command id would change to prql.openSqlPreview. Most extensions use ext. name as namespace, . for the command, view, or setting name separator and camel case for the names of those objects.

Below is the demo of new SQL Preview command, icon and Preview display. We can drop PRQL part from the preview panel title because it's clear that the panel is created by the PRQL extension as indicated by the panel icon in its titlebar.

Let's decide on what Create SQL Document or Compile to SQL and Run should look like in #42.

The proposed changes below should take care of standardizing auto-updated SQL Preview.

prql-sql-preview

Activity

  1. max-sixty commented on Feb 5, 2023

    @max-sixty
    Member

    Closing from #47. Excellent idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions