Repository navigation
Merged
Conversation
use /\\.prql$/" to match .prql filenames
- with prql.generateSqlFile command id - use built-in vscode $(database) icon for sql file - add it to editor title and context menus
max-sixty
reviewed
Feb 6, 2023
|
|
||
| export interface CompilationResult { | ||
| status: "ok" | "error"; | ||
| status: 'ok' | 'error'; |
Member
There was a problem hiding this comment.
If we should add a formatter for these, lmk, we have loads of devops in the main repo, but I haven't spent that much time with this repo
Collaborator
Author
There was a problem hiding this comment.
no big deal. I wanted to cleanup vscode imports and decided to do strings too.
Member
|
That's so nice @RandomFractals . Really cool, thank you! |
max-sixty
added a commit
that referenced
this pull request
Feb 6, 2023
This should automate some of the formatting changes folks are doing. From #49 (comment)
Merged
max-sixty
added a commit
that referenced
this pull request
Feb 6, 2023
This should automate some of the formatting changes folks are doing. From #49 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements basic Prql to Sql file generation workflow as described in #42.
I added database icon menu option to the editor title bar context menu as both prql and sql files use similar icons, and there are no other database related actions for open prql documents implemented by Prql extension currently.
Preview of integrated workflow with this functionality using DuckDB Sql Tools and sample
chinook.duckdband daily-invoice-totals.prql from our extension docs repo: