Skip to content

build(js): Fix wasm-pack's use of .gitignore #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 1 commit into from
Feb 19, 2023
Merged

build(js): Fix wasm-pack's use of .gitignore #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prql-js/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,4 @@ npm test
[^1]:
Though we would be very open to other approaches, given wasm-pack does not
seem maintained, and we're eliding many of its features to build for three
targets.
targets. See <https://github.com/PRQL/prql/issues/1836> for more details.
6 changes: 3 additions & 3 deletions prql-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
},
"scripts": {
"build": "npm run build:node && npm run build:bundler && npm run build:web",
"build:bundler": "wasm-pack build --target bundler --release --out-dir dist/bundler",
"build:node": "wasm-pack build --target nodejs --release --out-dir dist/node",
"build:web": "wasm-pack build --target no-modules --release --out-dir dist/web",
"build:bundler": "wasm-pack build --target bundler --release --out-dir dist/bundler && rm dist/bundler/.gitignore",
"build:node": "wasm-pack build --target nodejs --release --out-dir dist/node && rm dist/node/.gitignore",
"build:web": "wasm-pack build --target no-modules --release --out-dir dist/web && rm dist/web/.gitignore",
"test": "wasm-pack test --firefox && mocha tests"
},
"types": "dist/node/prql_js.d.ts",
Expand Down