Skip to content

[feat] Pinned workspaces named "local" are indistinguishable — the PINNED section drops the project name #7574

Closed

Description

@pdolega

What problem are you trying to solve?

The PINNED section pulls a workspace out of its project group. That's the whole point — but it also means the project name is no longer anywhere near the row.

Every project's main workspace is called local. So pin two of them and the sidebar shows this:

PINNED
  💻 🌍 local
  💻 🌑 local

Two identical rows. The only thing telling them apart is a 14px project avatar, which for most projects is a generated circle — I can't tell Flamaster from Bifrost at that size (or whatever projects I have). Inside a project group local is unambiguous because the group header says which project. Pinned, that context is gone.

I have to hover each row and wait for the tooltip to find out which is which, every time. Pinning is supposed to be the fast path.

Proposed solution

Show the project name in the row label, dimmed, as a path-style prefix:

PINNED
  💻 🌍 Flamaster/local
  💻 🌑 Bifrost/basic_optimization

Readable at a glance, no hover. Keep the avatar — it's still a useful color cue once you know which is which.

The data is already there: pinnedContext on the row carries projectName and projectIconUrl, and today only the icon is rendered (DashboardSidebarExpandedWorkspaceRow.tsx#L311). The name is passed in and thrown away.

Only pinned rows need this. Rows inside a project group already have their header. Project-less sessions can read Session/….

Workarounds you've tried

  • Hover the row — the tooltip does show the project name, but one row at a time, and it's the thing I'm trying to avoid.
  • Rename the workspace — not possible for a main workspace: onRename is undefined when isMainWorkspace, and the stored name is ignored in favour of "local".
  • Move it into a section I could name myself — the Create section / Move to section submenu is gated on !isLocalMainWorkspace, and grouping is hidden for pinned rows anyway.
  • Unpin and rely on the project groups — works, but gives up the feature.

Related

Superset 1.25.0, macOS (Darwin arm64).

Activity

  1. github-actions commented on Sep 15, 2026

    @github-actions
    Contributor

    Summary

    The request is for pinned sidebar rows to show their owning project in the label, because the PINNED section deliberately lifts a workspace out of its project group and the group header was the only thing naming the project. Since every project's main local checkout is created as local (DEFAULT_LOCAL_WORKSPACE_NAME), two pinned main workspaces render as two rows reading local, distinguished only by a 14px project avatar that for most projects is a single-letter fallback tile. I confirmed the described behavior in the code: the project name is already plumbed to the row and is used only as the avatar's letter seed and its hover tooltip — never as visible text.

    Affected code

    • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/DashboardSidebarExpandedWorkspaceRow.tsx:311-334 — the only consumer of pinnedContext. projectName feeds ProjectThumbnail's projectName prop (letter fallback / alt text) and the TooltipContent at :328. Nothing renders it inline.
    • Same file, :349-358 — the label is <WorkspaceNameMarquee name={name || branch} />, i.e. the workspace's own name with no project qualifier.
    • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarPinnedSection/DashboardSidebarPinnedSection.tsx:118-130 — builds pinnedContext from the dnd projectsById map, projectName: project?.name ?? null.
    • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/hooks/useDashboardSidebarData/buildDashboardSidebarProjects.ts:109 and apps/desktop/src/renderer/utils/getV2WorkspaceDisplayName/getV2WorkspaceDisplayName.ts:9 — row name is workspace.name || workspace.branch, nothing else.
    • packages/host-service/src/trpc/router/project/utils/create-local-workspace.ts:21 — DEFAULT_LOCAL_WORKSPACE_NAME = "local", the source of the collision across projects.
    • apps/desktop/src/renderer/routes/_authenticated/components/ProjectThumbnail/ProjectThumbnail.tsx:56-77 — the generated fallback is a bordered tile with projectName.charAt(0), rendered at size-3.5 text-[8px] by the pinned row. Two projects sharing a first letter are literally identical there, which matches the report.

    Root cause and what I ruled out

    Not a bug in data flow — DashboardSidebarPinnedWorkspace (types.ts:67-71) and pinnedContext both carry projectName, so this is purely a missing render in DashboardSidebarExpandedWorkspaceRow. Two things in the "workarounds" section don't match current main, so a maintainer shouldn't plan around them:

    • There is no isMainWorkspace anywhere in apps/desktop/src today. DashboardSidebarWorkspaceItem.tsx:307,397 passes onRename={startRename} unconditionally, and submitRename (useDashboardSidebarWorkspaceItemActions.ts:135-141) has no main-workspace guard — renaming the local row appears to be allowed now. The local label is just the default stored name, not a forced display string. (The helper that does hardcode "local", renderer/lib/getWorkspaceDisplayName/getWorkspaceDisplayName.ts:6, is dead — only its barrel re-exports it.)
    • The group actions are gated on !isPinned && canJoinGroup (DashboardSidebarWorkspaceContextMenu.tsx:201), i.e. hidden because the row is pinned, not because it's a local main workspace. So "move it into a section I could name" is blocked, as reported, but for a different reason.

    Neither weakens the request: even with a rename available, the default state ships ambiguous.

    Reproduction

    1. Have two projects registered with contrasting names but the same-ish avatar situation (no custom icon, ideally the same first letter, e.g. Bifrost / Bramble).
    2. Right-click each project's local workspace row → Pin.
    3. Expanded sidebar: the PINNED section shows two rows labelled local; the project is only recoverable by hovering the 14px avatar for the tooltip at DashboardSidebarExpandedWorkspaceRow.tsx:327.

    A cheap regression test would be a render test next to the component (DestroyConfirmPane.test.tsx in this tree is the precedent for component-level tests here): render the row twice with pinnedContext={{ projectName: "Bifrost", … }} / { projectName: "Bramble", … } and assert the two accessible labels differ. Better still, extract the label composition into a pure helper (e.g. utils/formatPinnedRowLabel/) and unit-test the three cases — project name present, null → Session, and empty workspace name falling back to branch.

    Fix direction

    Render the prefix as a sibling span before WorkspaceNameMarquee inside the minmax(0,1fr) name column at :336-358, gated on pinnedContext so only pinned rows change. Worth knowing before implementing:

    • The prefix must not steal the marquee's measured width: the marquee derives overflow from text.scrollWidth - container.clientWidth (WorkspaceNameMarquee.tsx:53), so the prefix belongs outside that container, and it needs a truncation/shrink policy of its own — a long project name would otherwise squeeze the workspace name it's meant to qualify. Pinned rows use indentation="top-level" (pl-2), so they have the most horizontal room of any row, which helps.
    • WorkspaceNameMarquee sets title={name} (:81), the row's de facto accessible hover text. A prefix rendered outside it won't appear there; if you want the full Project/workspace string discoverable, pass it explicitly or move the title up a level.
    • The null case already has a localized fallback (t({ message: "Session" }), used twice at :318 and :329) — reuse it rather than adding a third copy. This directory is in ENFORCED_DIRS (packages/i18n/test/enforced-dirs.ts:12), so any new visible text must go through Lingui, and the / separator should be a non-translated glue string rather than baked into a message id.
    • Two adjacent gaps if you want them in scope: the collapsed rail renders pinned rows with no pinnedContext at all (DashboardSidebarPinnedSection.tsx:61-68), so it has no project cue either; and DashboardSidebarPinnedWorkspace.projectName from buildDashboardSidebarPinnedWorkspaces (buildDashboardSidebarProjects.ts:177) is currently unused on the expanded path, which re-derives the same value from the dnd store — worth collapsing to one source while touching this.
  2. added a commit that references this issue on Sep 20, 2026
    1174327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions