Repository navigation
fix(desktop): show branch subtitle for main workspace list item when branch name differs - #1201
Conversation
📝 WalkthroughWalkthroughThe WorkspaceListItem component's branch subtitle display logic is enhanced to account for cases where a branch name exists and differs from the branch label, in addition to non-branch workspaces. The collapsed branch tooltip is updated to conditionally display the branch name when appropriate. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This addresses a big onboarding pain for folks adopting Superset on an existing repo. The problem In my case I added the repo when the main copy was on a feature branch, so the main workspace is now forever stuck named after that branch. Even though I have long ago moved it to main branch Is it intentional that the main workspace item can’t be renamed? Possible direction: I think the best long‑term fix is to allow renaming the main workspace (like worktrees). Also, having visibility into the actual branch (what this PR suggests) is valuable — I’m not sure though if it's a good idea to show it conditionally, and only have this condition for main worktree item. It feels like it it adds a lot of small inconsistencies. |
Honestly I feel like it's in a weird spot in general, I kinda like the Conductor approach of hiding the concept of the "main branch" entirely and just treating everything as a worktree. I think your approach is reasonable as a short-term fix though! |
Please no! :) I like Superset specifically for the fact it feels lower level in such things, gives me more control, etc... |
Description
Show the branch subtitle for the main (branch) workspace menu item only when the workspace name differs from the branch, so we avoid duplicate labels while still exposing the current branch when a custom name is used.
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
Release Notes