Repository navigation
feat(desktop): seed claude and codex as default terminal presets #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 2566
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 6246
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 2746
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 989
🏁 Script executed:
Repository: superset-sh/superset
Length of output: 24817
Critical:
initializeDefaultPresetsoverwrites existing user presets on upgrade.The column
terminalPresetsInitializedis uninitialized (null) for existing users after a schema migration. WhengetTerminalPresetsis called post-upgrade,!row.terminalPresetsInitializedevaluates totrue, and this function replaces any existingterminalPresetswith only the two defaults — destroying presets the user may have already created.Merge defaults with existing presets and deduplicate by name to avoid losing user-created presets and prevent adding defaults that match existing ones.
Proposed fix
function initializeDefaultPresets() { const row = getSettings(); if (row.terminalPresetsInitialized) return row.terminalPresets ?? []; - const presets: TerminalPreset[] = DEFAULT_PRESETS.map((p) => ({ + const existing = row.terminalPresets ?? []; + const existingNames = new Set(existing.map((p) => p.name.toLowerCase())); + + const newDefaults: TerminalPreset[] = DEFAULT_PRESETS + .filter((p) => !existingNames.has(p.name.toLowerCase())) + .map((p) => ({ id: crypto.randomUUID(), ...p, })); + const presets = [...existing, ...newDefaults]; + localDb .insert(settings) .values({🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AviPeltz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.