Repository navigation
Fix Cmd+K to clear terminal #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Cross-platform compatibility issue - Ctrl+K won't work on Windows/Linux.
The clear shortcut detection only checks
event.metaKey(Line 166), which is the Cmd key on Mac or the Windows key on Windows/Linux—not the Ctrl key. This means Ctrl+K won't trigger the clear functionality on Windows/Linux, even though the hotkey definition uses"meta+k"which per the comment inhotkeys.tsshould map to "Cmd on Mac, Ctrl on Windows/Linux."The check at Line 168 explicitly excludes
event.ctrlKey, further preventing Ctrl+K from working.Apply this diff to support both Cmd (Mac) and Ctrl (Windows/Linux):
This aligns with the pattern at Line 179 where both
metaKeyandctrlKeyare treated as alternatives for cross-platform modifier key support.📝 Committable suggestion
🤖 Prompt for AI Agents