Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
DATABASE_URL=postgresql://postgres:postgres@localhost:5432/superset
VITE_DEV_SERVER_PORT=4927
WEBSITE_URL=http://localhost:3001

# Neon MCP Server API key (for Claude Code integration)
NEON_API_KEY=your_neon_api_key_here
11 changes: 11 additions & 0 deletions .mcp.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"mcpServers": {
"neon": {
"command": "npx",
"args": ["-y", "@neondatabase/mcp-server-neon@0.6.5", "start"],
"env": {
"NEON_API_KEY": "${NEON_API_KEY}"
}
}
}
}
Comment on lines +1 to +11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Find documentation files and environment setup files
find . -type f \( -name "README.md" -o -name "AGENTS.md" -o -name ".env.example" -o -name ".env" \) 2>/dev/null | head -20

Repository: superset-sh/superset

Length of output: 288


🏁 Script executed:

# Check if there are other .mcp.json files or MCP-related configurations
find . -type f -name "*.json" | grep -i mcp

Repository: superset-sh/superset

Length of output: 75


🏁 Script executed:

# Search for references to NEON_API_KEY setup or documentation
rg "NEON_API_KEY" --type markdown --type text -A 3 -B 3

Repository: superset-sh/superset

Length of output: 92


🏁 Script executed:

# Look for any setup or installation documentation
find . -type f \( -name "*.md" -o -name "SETUP*" -o -name "INSTALL*" \) | head -20

Repository: superset-sh/superset

Length of output: 625


🏁 Script executed:

# Check .env.example for NEON_API_KEY
cat .env.example

Repository: superset-sh/superset

Length of output: 191


🏁 Script executed:

# Check AGENTS.md for Neon documentation
cat AGENTS.md

Repository: superset-sh/superset

Length of output: 9884


🏁 Script executed:

# Check README.md for setup instructions (first 100 lines)
head -100 README.md

Repository: superset-sh/superset

Length of output: 3690


🏁 Script executed:

# Search for NEON references in documentation
rg -i "neon" --type md -A 2 -B 2 | head -50

Repository: superset-sh/superset

Length of output: 1433


🏁 Script executed:

# Verify npx version pinning syntax works
echo "Testing if npx supports version pinning in package names..."
# Example: npx -y package-name@1.0.0
# This is standard npm package specification syntax
rg "npx.*@" | head -10

Repository: superset-sh/superset

Length of output: 215


Pin package version and add NEON_API_KEY setup documentation.

The .mcp.json configuration is valid, but two improvements are needed:

  1. Package version not pinned: npx -y @neondatabase/mcp-server-neon will always fetch the latest version, risking inconsistent behavior across environments. The codebase already uses version-pinned packages (e.g., npx shadcn@latest), so pin this package as well:
-      "args": ["-y", "@neondatabase/mcp-server-neon", "start"],
+      "args": ["-y", "@neondatabase/mcp-server-neon@1.0.0", "start"],
  1. Setup documentation missing: NEON_API_KEY is not documented anywhere. Add it to .env.example:
DATABASE_URL=postgresql://postgres:postgres@localhost:5432/superset
VITE_DEV_SERVER_PORT=4927
WEBSITE_URL=http://localhost:3001
+NEON_API_KEY=your_neon_api_key_here

Additionally, add a section to AGENTS.md explaining MCP server setup under the Database section.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In .mcp.json around lines 1 to 11 the mcp-server command uses an unpinned
package (@neondatabase/mcp-server-neon) and NEON_API_KEY is undocumented; pin
the package by changing the npx invocation to a specific version (e.g.,
@neondatabase/mcp-server-neon@<VERSION>) so builds are deterministic, add
NEON_API_KEY to .env.example with a short comment and placeholder value, and
update AGENTS.md under the Database section with a short subsection describing
how to obtain/set NEON_API_KEY and how to start the MCP server using the pinned
npx command.