Repository navigation
[codex] Bump xterm for WebGL atlas fix - #4892
Conversation
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 71052d0 on May 23, 2026 5:22pm UTC. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates Changesxterm beta dependency updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps the xterm package train across
Confidence Score: 5/5Safe to merge — pure dependency version bump with no code changes and a correctly regenerated lockfile. All three workspace package.json files and bun.lock are updated consistently. The intentional one-step offset of @xterm/addon-webgl (beta.219) vs the rest of the train (beta.220) is by upstream design, and the resolved peer dependency in the lockfile (^6.1.0-beta.220) is correctly satisfied by the installed @xterm/xterm@6.1.0-beta.220. No logic, configuration, or API surface changes are introduced. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/package.json | Bumps 10 xterm add-ons from beta.219→beta.220 and @xterm/addon-webgl from beta.218→beta.219; xterm core and headless follow the beta.220 train. |
| apps/web/package.json | Bumps @xterm/addon-fit and @xterm/xterm from beta.219 to beta.220, consistent with the rest of the monorepo. |
| packages/host-service/package.json | Bumps @xterm/headless from beta.219 to beta.220, matching the monorepo-wide version alignment. |
| bun.lock | Lockfile regenerated to reflect all xterm version bumps; resolved peer dependency for @xterm/addon-webgl@0.20.0-beta.219 correctly pins to ^6.1.0-beta.220. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before
xterm_old["@xterm/xterm 6.1.0-beta.219"]
webgl_old["@xterm/addon-webgl 0.20.0-beta.218"]
addons_old["Other add-ons beta.219"]
end
subgraph After
xterm_new["@xterm/xterm 6.1.0-beta.220"]
webgl_new["@xterm/addon-webgl 0.20.0-beta.219 WebGL fix"]
addons_new["Other add-ons beta.220"]
end
webgl_new -->|peer ^6.1.0-beta.220| xterm_new
addons_new -->|peer ^6.1.0-beta.220| xterm_new
Reviews (1): Last reviewed commit: "Bump xterm for WebGL atlas fix" | Re-trigger Greptile
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Summary
@xterm/addon-webglto0.20.0-beta.219, which contains the WebGL atlas merge fix.@xterm/xterm,@xterm/headless, and the other xterm add-ons on the matchingbeta.220peer train and refreshesbun.lock.Why
Upstream fixed WebGL rendering corruption caused by stale atlas texture/page state after atlas page merges. Keeping the linked xterm packages aligned avoids prerelease peer drift while taking the WebGL fix.
Validation
bun install --frozen-lockfilebun run lintbun run typecheck --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-servicebunx turbo run test --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-serviceBuild check attempted with
bunx turbo run build --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-service, but local build completion was blocked by missing production web env vars and the desktopdist/main/pty-daemon.jsartifact check.Summary by cubic
Bumps
@xterm/xtermand related add-ons across desktop, web, and host-service to pick up the WebGL atlas merge fix, preventing terminal rendering corruption. Keeps all xterm packages on the samebeta.220peer train.apps/desktop:@xterm/*frombeta.219tobeta.220;@xterm/addon-webglto0.20.0-beta.219.apps/web:@xterm/addon-fitand@xterm/xtermtobeta.220.packages/host-service:@xterm/headlessto6.1.0-beta.220.bun.lock.Written for commit 71052d0. Summary will update on new commits. Review in cubic
Summary by CodeRabbit