Skip to content

[codex] Bump xterm for WebGL atlas fix - #4892

Merged
Kitenite merged 1 commit into
mainfrom
bump-xterm-5883-fix
May 23, 2026
Merged

Kitenite merged 1 commit into
mainfrom
bump-xterm-5883-fix

Conversation

@Kitenite

@Kitenite Kitenite commented May 23, 2026 •

Copy link
Copy Markdown
Member

Summary

Why

Upstream fixed WebGL rendering corruption caused by stale atlas texture/page state after atlas page merges. Keeping the linked xterm packages aligned avoids prerelease peer drift while taking the WebGL fix.

Validation

  • bun install --frozen-lockfile
  • bun run lint
  • bun run typecheck --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-service
  • bunx turbo run test --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-service

Build check attempted with bunx turbo run build --filter=@superset/desktop --filter=@superset/web --filter=@superset/host-service, but local build completion was blocked by missing production web env vars and the desktop dist/main/pty-daemon.js artifact check.


Open in Stage

Summary by cubic

Bumps @xterm/xterm and related add-ons across desktop, web, and host-service to pick up the WebGL atlas merge fix, preventing terminal rendering corruption. Keeps all xterm packages on the same beta.220 peer train.

  • Dependencies
    • apps/desktop: @xterm/* from beta.219 to beta.220; @xterm/addon-webgl to 0.20.0-beta.219.
    • apps/web: @xterm/addon-fit and @xterm/xterm to beta.220.
    • packages/host-service: @xterm/headless to 6.1.0-beta.220.
    • Refreshed bun.lock.

Written for commit 71052d0. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated terminal libraries to the latest beta versions across desktop, web, and host service applications, improving terminal rendering and functionality.

Review Change Stack

@ghost

ghost commented May 23, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Update xterm dependencies across workspace
2 Other changes
Open in Stage

Chapters generated by Stage for commit 71052d0 on May 23, 2026 5:22pm UTC.

@capy-ai

capy-ai Bot commented May 23, 2026

Copy link
Copy Markdown

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

@coderabbitai

coderabbitai Bot commented May 23, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ebed5476-fe61-4770-b79c-48e702f162fa

📥 Commits

Reviewing files that changed from the base of the PR and between cf8f945 and 71052d0.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • apps/desktop/package.json
  • apps/web/package.json
  • packages/host-service/package.json

📝 Walkthrough

Walkthrough

This PR updates @xterm package versions to beta.220 across the monorepo. The desktop application receives comprehensive addon and core package updates, while the web and host-service applications receive targeted version bumps to maintain consistency.

Changes

xterm beta dependency updates

Layer / File(s) Summary
Desktop app comprehensive xterm updates
apps/desktop/package.json
Eight @xterm addon packages (clipboard, fit, image, ligatures, progress, search, serialize, unicode11) and three core packages (@xterm/addon-webgl, @xterm/headless, @xterm/xterm) are updated to beta.220 releases.
Web and host-service xterm updates
apps/web/package.json, packages/host-service/package.json
Web app updates @xterm/addon-fit and @xterm/xterm to beta.220. Host-service updates @xterm/headless to beta.220, aligning with the desktop application updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • superset-sh/superset#4792: Direct predecessor that performed the same xterm version-bump work (beta.219 → beta.220) across the same three package.json files.
  • superset-sh/superset#4640: Related PR that bundles @xterm/headless into the standalone CLI distribution, making this dependency version update relevant to that feature.

Poem

🐰 A tiny hop through xterm's beta sea,
From 219 to 220, three files agree—
Desktop, web, and service in perfect sync,
No breaking changes, just a stable link! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping xterm packages to fix a WebGL rendering issue, which aligns with the primary objectives.
Description check ✅ Passed The description includes a clear summary, rationale, and comprehensive validation steps, though it deviates from the template structure with custom sections instead of the standard template format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-xterm-5883-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the xterm package train across desktop, web, and host-service to pick up the WebGL atlas merge fix from upstream (xtermjs/xterm.js#5883).

  • @xterm/addon-webgl moves from 0.20.0-beta.218 → 0.20.0-beta.219 (the fix release); all other xterm packages advance from beta.219 → beta.220 to stay on the aligned peer train.
  • bun.lock is regenerated consistently; the resolved peer dependency for @xterm/addon-webgl@0.20.0-beta.219 correctly resolves against @xterm/xterm@6.1.0-beta.220 via its ^6.1.0-beta.220 peer range.
  • No code changes — purely a dependency version update across three workspace roots.

Confidence Score: 5/5

Safe to merge — pure dependency version bump with no code changes and a correctly regenerated lockfile.

All three workspace package.json files and bun.lock are updated consistently. The intentional one-step offset of @xterm/addon-webgl (beta.219) vs the rest of the train (beta.220) is by upstream design, and the resolved peer dependency in the lockfile (^6.1.0-beta.220) is correctly satisfied by the installed @xterm/xterm@6.1.0-beta.220. No logic, configuration, or API surface changes are introduced.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/package.json Bumps 10 xterm add-ons from beta.219→beta.220 and @xterm/addon-webgl from beta.218→beta.219; xterm core and headless follow the beta.220 train.
apps/web/package.json Bumps @xterm/addon-fit and @xterm/xterm from beta.219 to beta.220, consistent with the rest of the monorepo.
packages/host-service/package.json Bumps @xterm/headless from beta.219 to beta.220, matching the monorepo-wide version alignment.
bun.lock Lockfile regenerated to reflect all xterm version bumps; resolved peer dependency for @xterm/addon-webgl@0.20.0-beta.219 correctly pins to ^6.1.0-beta.220.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before
        xterm_old["@xterm/xterm 6.1.0-beta.219"]
        webgl_old["@xterm/addon-webgl 0.20.0-beta.218"]
        addons_old["Other add-ons beta.219"]
    end
    subgraph After
        xterm_new["@xterm/xterm 6.1.0-beta.220"]
        webgl_new["@xterm/addon-webgl 0.20.0-beta.219 WebGL fix"]
        addons_new["Other add-ons beta.220"]
    end
    webgl_new -->|peer ^6.1.0-beta.220| xterm_new
    addons_new -->|peer ^6.1.0-beta.220| xterm_new
Loading

Reviews (1): Last reviewed commit: "Bump xterm for WebGL atlas fix" | Re-trigger Greptile

@Kitenite
Kitenite merged commit 00f5dd7 into main May 23, 2026
15 of 16 checks passed
@Kitenite
Kitenite deleted the bump-xterm-5883-fix branch May 23, 2026 17:24
@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

This branch was previously deployed

1 inactive deployment
preview — 71052d0f Deployed May 23, 2026 by Kitenite via Deploy API #5738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant