Repository navigation
fix(desktop): bump shell-quote to 1.8.4 (Dependabot #166) - #5267
Conversation
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit d381347 on Jun 14, 2026 9:10pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changesshell-quote version bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryBumps
Confidence Score: 5/5Safe to merge — the change is a minimal, API-compatible patch release with no source modifications required. The bump is isolated to dependency metadata: the direct dep, root overrides, and lockfile are all consistent, and the lockfile confirms zero remaining 1.8.3 references. Both transitive consumers (react-devtools-core, teen_process) are properly covered by the overrides entry. No call-site changes are needed since 1.8.4 is fully backward-compatible. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/package.json | Direct shell-quote dependency bumped from 1.8.3 to 1.8.4 to address the newline-escaping vulnerability in quote(). |
| package.json | Root overrides entry for shell-quote@1.8.4 added to ensure transitive consumers (react-devtools-core, teen_process) are also pinned to the patched version. |
| bun.lock | Lock file regenerated; all shell-quote references resolve to 1.8.4 with zero remaining 1.8.3 entries confirmed. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["package.json\noverrides: shell-quote@1.8.4"] --> B["bun install resolution"]
C["apps/desktop/package.json\nshell-quote@1.8.4 (direct)"] --> B
B --> D["shell-quote@1.8.4\n(single resolved version)"]
E["react-devtools-core\n(transitive, ^1.6.1)"] -->|"forced via overrides"| D
F["teen_process\n(transitive, ^1.8.1)"] -->|"forced via overrides"| D
D --> G["quote() now escapes\nnewlines in .op values ✓"]
Reviews (1): Last reviewed commit: "fix(desktop): bump shell-quote to 1.8.4 ..." | Re-trigger Greptile
There was a problem hiding this comment.
No issues found across 3 files
Architecture diagram
sequenceDiagram
participant Pkg as Root package.json
participant Dep as apps/desktop/package.json
participant Lock as bun.lock
participant Trans as Transitive Dependencies
participant Desktop as Desktop App (Runtime)
participant Shell as shell-quote@1.8.4
participant OS as Operating System
Note over Pkg,OS: Dependency Resolution & Runtime Flow
Pkg->>Lock: overrides: shell-quote@1.8.4 enforced
Dep->>Lock: direct: shell-quote@1.8.4
Lock->>Lock: Resolves all shell-quote references to single 1.8.4
Lock->>Trans: Forces shell-quote@1.8.4 for react-devtools-core, teen_process
alt Build Time
Desktop->>Dep: Reads dependencies
Dep-->>Desktop: shell-quote@1.8.4
Desktop->>Lock: Resolves version
Lock-->>Desktop: 1.8.4 (no 1.8.3)
else Runtime - Command Execution
Desktop->>Shell: require('shell-quote')
Shell->>Shell: Exports quote() and parse()
Desktop->>Shell: quote([object]) with .op values
Shell->>Shell: Escapes newlines in .op values (fixed in 1.8.4)
Shell-->>Desktop: Properly escaped command string
Desktop->>OS: Execute shell command (e.g., preset launch)
OS-->>Desktop: Command executed successfully
else Runtime - Malformed Input (pre-1.8.3)
Note over Desktop,OS: Previously: quote() did not escape newlines in .op values
Desktop->>Shell: quote([{op: 'value\ninjection'}])
Shell-->>Desktop: Unescaped newline in output
Desktop->>OS: Malformed command executed
OS-->>Desktop: Potential command injection or failure
end
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Summary
Resolves Dependabot critical alert #166:
shell-quote'squote()does not escape newlines in object.opvalues. Fixed inshell-quote@1.8.4.apps/desktop/package.jsonfrom1.8.3→1.8.4.overridesentry forcingshell-quoteto1.8.4, since transitive deps (react-devtools-core,teen_process) still pulled in1.8.3.bun.lock— now resolves to a singleshell-quote@1.8.4, zero1.8.3references.No source changes needed —
1.8.4is API-compatible, so existingquote()/parse()call sites are unaffected.Test Plan
bun installresolves cleanly with noshell-quote@1.8.3inbun.lockSummary by cubic
Update
shell-quoteto 1.8.4 to patch newline escaping inquote()and prevent malformed command construction in Desktop. Enforce the patched version via a root override so no packages resolve to 1.8.3 (addresses Dependabot alert #166).apps/desktopdirect dep:shell-quote1.8.3→1.8.4.overridesforshell-quote@1.8.4and updatedbun.lockto a single version.Written for commit d381347. Summary will update on new commits.
Summary by CodeRabbit