Skip to content

fix(desktop): bump shell-quote to 1.8.4 (Dependabot #166) - #5267

Merged
AviPeltz merged 1 commit into
mainfrom
fix-shell-quote-newlines
Jun 14, 2026
Merged

AviPeltz merged 1 commit into
mainfrom
fix-shell-quote-newlines

Conversation

@AviPeltz

@AviPeltz AviPeltz commented Jun 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Resolves Dependabot critical alert #166: shell-quote's quote() does not escape newlines in object .op values. Fixed in shell-quote@1.8.4.

  • Bumped the direct dependency in apps/desktop/package.json from 1.8.3 → 1.8.4.
  • Added a root overrides entry forcing shell-quote to 1.8.4, since transitive deps (react-devtools-core, teen_process) still pulled in 1.8.3.
  • Regenerated bun.lock — now resolves to a single shell-quote@1.8.4, zero 1.8.3 references.

No source changes needed — 1.8.4 is API-compatible, so existing quote()/parse() call sites are unaffected.

Test Plan


Open in Stage

Summary by cubic

Update shell-quote to 1.8.4 to patch newline escaping in quote() and prevent malformed command construction in Desktop. Enforce the patched version via a root override so no packages resolve to 1.8.3 (addresses Dependabot alert #166).

  • Dependencies
    • Bumped apps/desktop direct dep: shell-quote 1.8.3 → 1.8.4.
    • Added root overrides for shell-quote@1.8.4 and updated bun.lock to a single version.

Written for commit d381347. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated dependencies to their latest patch versions for improved stability and security.

@ghost

ghost commented Jun 14, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 3 individual chapters for you:

Title
1 Bump shell-quote dependency in desktop app
2 Enforce shell-quote version via root overrides
3 Other changes
Open in Stage

Chapters generated by Stage for commit d381347 on Jun 14, 2026 9:10pm UTC.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: de006e9e-f278-4528-9be4-d91ee4b1e67b

📥 Commits

Reviewing files that changed from the base of the PR and between c174c5a and d381347.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • apps/desktop/package.json
  • package.json

📝 Walkthrough

Walkthrough

shell-quote is bumped from 1.8.3 to 1.8.4 in apps/desktop/package.json, and a corresponding version override (1.8.4) is added to the root package.json overrides block to enforce this version across the workspace.

Changes

shell-quote version bump

Layer / File(s) Summary
shell-quote bump in desktop and root overrides
apps/desktop/package.json, package.json
apps/desktop/package.json updates the direct shell-quote dependency from 1.8.3 to 1.8.4; root package.json adds shell-quote: 1.8.4 to the overrides block to pin the version workspace-wide.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A version tick, a tiny hop,
shell-quote moves up, one patch on top.
The rabbit checks the lockfile neat,
1.8.4 makes the upgrade complete.
🐇 One small bump, a safer treat!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: bumping shell-quote to 1.8.4 to fix a critical security vulnerability, directly reflecting the changeset's primary objective.
Description check ✅ Passed The description comprehensively covers the fix, explains why both direct and override updates were needed, and includes a clear test plan, matching the repository template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-shell-quote-newlines

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Bumps shell-quote from 1.8.3 → 1.8.4 to resolve a Dependabot critical alert where quote() failed to escape newlines in object .op values. The fix is applied both as a direct dependency and as a root-level overrides entry to cover transitive consumers (react-devtools-core, teen_process).

  • apps/desktop/package.json: direct dep pinned to 1.8.4.
  • package.json: root overrides block extended with \"shell-quote\": \"1.8.4\" so all transitive resolutions are forced to the patched version.
  • bun.lock: regenerated cleanly — confirmed zero remaining 1.8.3 references across the full lockfile.

Confidence Score: 5/5

Safe to merge — the change is a minimal, API-compatible patch release with no source modifications required.

The bump is isolated to dependency metadata: the direct dep, root overrides, and lockfile are all consistent, and the lockfile confirms zero remaining 1.8.3 references. Both transitive consumers (react-devtools-core, teen_process) are properly covered by the overrides entry. No call-site changes are needed since 1.8.4 is fully backward-compatible.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/package.json Direct shell-quote dependency bumped from 1.8.3 to 1.8.4 to address the newline-escaping vulnerability in quote().
package.json Root overrides entry for shell-quote@1.8.4 added to ensure transitive consumers (react-devtools-core, teen_process) are also pinned to the patched version.
bun.lock Lock file regenerated; all shell-quote references resolve to 1.8.4 with zero remaining 1.8.3 entries confirmed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["package.json\noverrides: shell-quote@1.8.4"] --> B["bun install resolution"]
    C["apps/desktop/package.json\nshell-quote@1.8.4 (direct)"] --> B
    B --> D["shell-quote@1.8.4\n(single resolved version)"]
    E["react-devtools-core\n(transitive, ^1.6.1)"] -->|"forced via overrides"| D
    F["teen_process\n(transitive, ^1.8.1)"] -->|"forced via overrides"| D
    D --> G["quote() now escapes\nnewlines in .op values ✓"]
Loading

Reviews (1): Last reviewed commit: "fix(desktop): bump shell-quote to 1.8.4 ..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Architecture diagram
sequenceDiagram
    participant Pkg as Root package.json
    participant Dep as apps/desktop/package.json
    participant Lock as bun.lock
    participant Trans as Transitive Dependencies
    participant Desktop as Desktop App (Runtime)
    participant Shell as shell-quote@1.8.4
    participant OS as Operating System

    Note over Pkg,OS: Dependency Resolution & Runtime Flow

    Pkg->>Lock: overrides: shell-quote@1.8.4 enforced
    Dep->>Lock: direct: shell-quote@1.8.4
    Lock->>Lock: Resolves all shell-quote references to single 1.8.4
    Lock->>Trans: Forces shell-quote@1.8.4 for react-devtools-core, teen_process

    alt Build Time
        Desktop->>Dep: Reads dependencies
        Dep-->>Desktop: shell-quote@1.8.4
        Desktop->>Lock: Resolves version
        Lock-->>Desktop: 1.8.4 (no 1.8.3)
    else Runtime - Command Execution
        Desktop->>Shell: require('shell-quote')
        Shell->>Shell: Exports quote() and parse()
        Desktop->>Shell: quote([object]) with .op values
        Shell->>Shell: Escapes newlines in .op values (fixed in 1.8.4)
        Shell-->>Desktop: Properly escaped command string
        Desktop->>OS: Execute shell command (e.g., preset launch)
        OS-->>Desktop: Command executed successfully
    else Runtime - Malformed Input (pre-1.8.3)
        Note over Desktop,OS: Previously: quote() did not escape newlines in .op values
        Desktop->>Shell: quote([{op: 'value\ninjection'}])
        Shell-->>Desktop: Unescaped newline in output
        Desktop->>OS: Malformed command executed
        OS-->>Desktop: Potential command injection or failure
    end
Loading

Re-trigger cubic

@AviPeltz
AviPeltz merged commit 30ab567 into main Jun 14, 2026
16 checks passed
@github-actions

github-actions Bot commented Jun 14, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

This branch was previously deployed

1 inactive deployment
preview — d3813476 Deployed Jun 14, 2026 by AviPeltz via Deploy API #5975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant