Repository navigation
fix(desktop): spinner for v2 changes loading + delayed file/change tree tooltips - #5410
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a configurable delay (default 500ms) before ShadowClickHint's hover tooltip appears, using a timer that re-validates the hovered row and clears on leave/unmount. FileRow's tooltip now sets delayDuration={500}. ChangesTabContent's loading state now renders a Spinner alongside the loading text. ChangesSidebar interaction and loading updates
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Pointer
participant ShadowClickHint
participant TimerRef
Pointer->>ShadowClickHint: handleMouseOver(row)
ShadowClickHint->>TimerRef: clearTimer()
ShadowClickHint->>TimerRef: setTimeout(delayMs)
TimerRef-->>ShadowClickHint: timeout fires
ShadowClickHint->>ShadowClickHint: check hovered row still matches
ShadowClickHint->>ShadowClickHint: setHoverRect(anchor)
Pointer->>ShadowClickHint: handleMouseLeave()
ShadowClickHint->>TimerRef: clearTimer()
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit 860993a on Jul 2, 2026 3:52pm UTC. |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Small polish to the v2 workspace sidebar:
Spinner(@superset/ui/spinner), sized to match the files loading spinner.FileRow):delayDuration={500}on the row<Tooltip>.ShadowClickHint): this hint is a forced-opentooltip, sodelayDurationdoesn't apply — added a hover timer (default 500ms) before the hint anchors, cleared on row-change/leave/unmount.Test Plan
Summary by CodeRabbit