Repository navigation
feat(marketing): source agent skills from superset-sh/skills, drop monorepo copy - #5919
Conversation
…norepo copy The official skills now live in the public superset-sh/skills repo (registered on skills.sh via npx skills add superset-sh/skills; the old private skills repo moved to sales-skills). The /.well-known/agent-skills routes fetch SKILL.md files from that repo with 1h ISR instead of reading a checked-in copy, and now serve both skills (superset CLI + superset-mcp). llms.txt links the repo. Claude-Session: https://claude.ai/code/session_01GbjRvApZBmhsSkfHzihp6x
The plugin symlinked ../../skills/superset, which the skills-repo migration removed. superset-sh/skills is canonical; the plugin carries a copy because plugin distribution needs the file on disk. Claude-Session: https://claude.ai/code/session_01GbjRvApZBmhsSkfHzihp6x
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds shared retrieval for supported agent skills, JSON and Markdown discovery endpoints, Superset CLI skill documentation, and installation links in marketing and integration docs. ChangesAgent skills discovery
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant IndexRoute
participant SkillSource
participant GitHubRawRepository
Client->>IndexRoute: GET index.json
IndexRoute->>SkillSource: Fetch supported skills
SkillSource->>GitHubRawRepository: Request SKILL.md files
GitHubRawRepository-->>SkillSource: Markdown content
SkillSource-->>IndexRoute: Skill content or null
IndexRoute-->>Client: JSON discovery index
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/marketing/src/app/.well-known/agent-skills/skills-source.ts`:
- Around line 10-17: Update fetchSkill to catch both fetch and response.text()
failures, returning null for any remote error so callers retain their fallback
behavior. Add a bounded timeout to the remote request using the existing fetch
cancellation pattern before relying on next.revalidate, while preserving the
current null result for non-OK responses.
In `@plugins/superset/skills/superset/SKILL.md`:
- Line 18: Update the “Plan work” workflow instruction to use the complete
`superset tasks update <id-or-slug>` command, matching the existing `superset
tasks create` command.
- Line 122: Update the automation documentation around the project ID
prerequisite and the workspace examples to distinguish project-scoped and
workspace-scoped operations: clarify when --project is required versus optional,
and reconcile the statements about whether runs always create a workspace or
only create one when --workspace is omitted. Ensure the documented behavior is
consistent across the prerequisite text and examples.
- Line 11: Replace the direct curl-to-sh installation command in the Superset
CLI instructions with a safer installation method, preferably a package manager
or signed release. If no alternative exists, document downloading a pinned
script or release, verifying its integrity against a trusted checksum or
signature, and only then executing it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 33f5c92d-8fbf-4945-aeb5-ed6a44a9101c
📒 Files selected for processing (7)
apps/marketing/src/app/.well-known/agent-skills/[skill]/SKILL.md/route.tsapps/marketing/src/app/.well-known/agent-skills/index.json/route.tsapps/marketing/src/app/.well-known/agent-skills/skills-source.tsapps/marketing/src/app/.well-known/agent-skills/superset/SKILL.md/route.tsapps/marketing/src/lib/llms.tsplugins/superset/skills/supersetplugins/superset/skills/superset/SKILL.md
💤 Files with no reviewable changes (2)
- plugins/superset/skills/superset
- apps/marketing/src/app/.well-known/agent-skills/superset/SKILL.md/route.ts
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/marketing/src/app/.well-known/agent-skills/skills-source.ts`:
- Around line 10-17: Update fetchSkill to catch both fetch and response.text()
failures, returning null for any remote error so callers retain their fallback
behavior. Add a bounded timeout to the remote request using the existing fetch
cancellation pattern before relying on next.revalidate, while preserving the
current null result for non-OK responses.
In `@plugins/superset/skills/superset/SKILL.md`:
- Line 18: Update the “Plan work” workflow instruction to use the complete
`superset tasks update <id-or-slug>` command, matching the existing `superset
tasks create` command.
- Line 122: Update the automation documentation around the project ID
prerequisite and the workspace examples to distinguish project-scoped and
workspace-scoped operations: clarify when --project is required versus optional,
and reconcile the statements about whether runs always create a workspace or
only create one when --workspace is omitted. Ensure the documented behavior is
consistent across the prerequisite text and examples.
- Line 11: Replace the direct curl-to-sh installation command in the Superset
CLI instructions with a safer installation method, preferably a package manager
or signed release. If no alternative exists, document downloading a pinned
script or release, verifying its integrity against a trusted checksum or
signature, and only then executing it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 33f5c92d-8fbf-4945-aeb5-ed6a44a9101c
📒 Files selected for processing (7)
apps/marketing/src/app/.well-known/agent-skills/[skill]/SKILL.md/route.tsapps/marketing/src/app/.well-known/agent-skills/index.json/route.tsapps/marketing/src/app/.well-known/agent-skills/skills-source.tsapps/marketing/src/app/.well-known/agent-skills/superset/SKILL.md/route.tsapps/marketing/src/lib/llms.tsplugins/superset/skills/supersetplugins/superset/skills/superset/SKILL.md
💤 Files with no reviewable changes (2)
- plugins/superset/skills/superset
- apps/marketing/src/app/.well-known/agent-skills/superset/SKILL.md/route.ts
🛑 Comments failed to post (4)
apps/marketing/src/app/.well-known/agent-skills/skills-source.ts (1)
10-17: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail echo "== locate file ==" git ls-files | rg 'apps/marketing/src/app/.well-known/agent-skills/skills-source\.ts|agent-skills' || true echo "== file excerpt ==" if [ -f apps/marketing/src/app/.well-known/agent-skills/skills-source.ts ]; then cat -n apps/marketing/src/app/.well-known/agent-skills/skills-source.ts fi echo "== search fetchSkill usages ==" rg -n "fetchSkill|Promise\.all|agent-skills|AgentSkills" apps/marketing/src/app/.well-known apps/marketing/src 2>/dev/null || trueRepository: superset-sh/superset
Length of output: 2100
🏁 Script executed:
#!/bin/bash set -euo pipefail node - <<'JS' (async () => { const results = await Promise.allSettled([ (async () => { const response = await fetch("https://httpbin.org/status/404"); if (!response.ok) return true; return await response.text(); })().then(() => false), fetch("https://127.0.0.1:1").then(async response => response.ok ? await response.text() : null).then(() => false), ]); console.log("rejected responses:", results.some(r => r.status === "rejected")); console.log("reasons:", results.map(r => r.status === "rejected" ? r.reason && r.reason.name : null)); })().catch(e => { console.error("probe thrown:", e && e.name); process.exitCode = 1; }); JSRepository: superset-sh/superset
Length of output: 214
Handle rejected
fetchSkillfetches before route composition.
fetchSkillonly returnsnullfor non-OK responses; network failures andresponse.text()read failures still reject. Since the index route awaitsPromise.all([fetchSkill(...), ...])and the per-skill route awaitsfetchSkill(...)directly, those routes can surface a 500 instead of the fallback. Catch the fetch plus body read insidefetchSkill, returnnullon failure, and apply a bounded remote-timeout before relying onnext.revalidate.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/marketing/src/app/.well-known/agent-skills/skills-source.ts` around lines 10 - 17, Update fetchSkill to catch both fetch and response.text() failures, returning null for any remote error so callers retain their fallback behavior. Add a bounded timeout to the remote request using the existing fetch cancellation pattern before relying on next.revalidate, while preserving the current null result for non-OK responses.plugins/superset/skills/superset/SKILL.md (3)
11-11: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail printf 'File context:\n' sed -n '1,80p' plugins/superset/skills/superset/SKILL.md || true printf '\nSearch for similar install commands nearby:\n' rg -n 'curl .*superset|superset\.sh/cli/install|pip install|\.install\.sh' plugins/superset || true printf '\nRepository files for superset skill/docs:\n' fd -p 'plugins/superset/skills/superset|plugins/superset' . --type f | sed -n '1,120p'Repository: superset-sh/superset
Length of output: 5156
Do not pipe an unpinned remote script directly into
sh.The install step downloads and executes mutable upstream code without inspection or integrity verification. Prefer a package manager or signed release; otherwise document a download-then-verify-pinned-checksum flow before execution.
🧰 Tools
🪛 SkillSpector (2.3.11)
[error] 11: [SC2] External Script Fetching: Remote code is downloaded and executed. This bypasses code review and could introduce malicious code.
Remediation: Avoid downloading and executing remote scripts. Use trusted packages from PyPI/npm. If remote fetch is required, verify checksums and use HTTPS.
(Supply Chain (SC2))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/superset/skills/superset/SKILL.md` at line 11, Replace the direct curl-to-sh installation command in the Superset CLI instructions with a safer installation method, preferably a package manager or signed release. If no alternative exists, document downloading a pinned script or release, verifying its integrity against a trusted checksum or signature, and only then executing it.Source: Linters/SAST tools
18-18: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the full CLI command in the core workflow.
tasks update <id-or-slug>omits thesupersetexecutable, so copying the documented step fails in a normal shell. Change it tosuperset tasks update <id-or-slug>.🧰 Tools
🪛 SkillSpector (2.3.11)
[error] 11: [SC2] External Script Fetching: Remote code is downloaded and executed. This bypasses code review and could introduce malicious code.
Remediation: Avoid downloading and executing remote scripts. Use trusted packages from PyPI/npm. If remote fetch is required, verify checksums and use HTTPS.
(Supply Chain (SC2))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/superset/skills/superset/SKILL.md` at line 18, Update the “Plan work” workflow instruction to use the complete `superset tasks update <id-or-slug>` command, matching the existing `superset tasks create` command.
122-122: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Align the project/workspace prerequisites in the automation documentation.
Line 122 says a project ID is required to schedule automations, but the later workspace-only example permits omitting
--project. Also, line 134 says every run produces a workspace, while line 137 says a new workspace is created only when--workspaceis omitted. Document the project-scoped versus workspace-scoped behavior explicitly.Also applies to: 134-137
🧰 Tools
🪛 SkillSpector (2.3.11)
[error] 11: [SC2] External Script Fetching: Remote code is downloaded and executed. This bypasses code review and could introduce malicious code.
Remediation: Avoid downloading and executing remote scripts. Use trusted packages from PyPI/npm. If remote fetch is required, verify checksums and use HTTPS.
(Supply Chain (SC2))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/superset/skills/superset/SKILL.md` at line 122, Update the automation documentation around the project ID prerequisite and the workspace examples to distinguish project-scoped and workspace-scoped operations: clarify when --project is required versus optional, and reconcile the statements about whether runs always create a workspace or only create one when --workspace is omitted. Ensure the documented behavior is consistent across the prerequisite text and examples.
Summary
anthropics/skills,cloudflare/skills,openai/skills). The previous privatesuperset-sh/skills(sales-outreach commands) was renamed tosuperset-sh/sales-skills; GitHub redirects both old names.supersetCLI skill (moved verbatim) and a newsuperset-mcpskill (MCP setup one-liners, auth flow, tool catalog) — and is registered on skills.sh (npx skills add superset-sh/skillsverified: both skills install).skills/superset/and repoints consumers:/.well-known/agent-skills/index.json+/{skill}/SKILL.mdnow fetch from the skills repo with 1h ISR (single dynamic route replaces the hardcoded one; serves both skills; unknown names 404; source outage → 503 with ISR serving stale-good in practice).plugins/superset) symlinked the deleted path — it now vendors a real copy, since plugin distribution needs the file on disk.Why / Context
skills.sh only counts self-published official skills (published from the vendor's own org). Ours lived inside the monorepo, so scans saw only "1 community skill with potential relation." Follow-up to the agent-readiness series (#5910/#5912/#5917).
Manual QA Checklist
npx skills add superset-sh/skills --allinstalls both skills into.agents/skills/(universal + Claude Code symlinks)/.well-known/agent-skills/index.jsonlists both skills with descriptions + sha256 digests, sourced live from GitHub/{skill}/SKILL.mdserves text/markdown for both; unknown skill name → 404bun run lintexits 0 (caught and fixed the plugin's broken symlink)Known Limitations
plugins/superset/skills/superset/.Summary by cubic
Move official agent skills to the public
superset-sh/skillsrepo and drop the monorepo copy. Marketing now fetches skills from GitHub and serves bothsupersetandsuperset-mcp; docs now point agents to the repo and install command.New Features
/.well-known/agent-skills/{skill}/SKILL.mddynamically fetches fromsuperset-sh/skillswith 1h ISR; supportssupersetandsuperset-mcp(unknown → 404, source outage → 503)./.well-known/agent-skills/index.jsonbuilds from live content with sha256 digests and includesrepository: https://github.com/superset-sh/skills.Migration
skills/superset/from the monorepo; the Claude Code plugin now vendors the CLI skill file on disk.npx skills add superset-sh/skills.Written for commit b27e072. Summary will update on new commits.
Summary by CodeRabbit
supersetCLI workflow documentation, including commands, environment variables, sessions, and troubleshooting.