Repository navigation
chore(desktop): remove resource_snapshot and relay_ws_* telemetry events - #5964
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (14)
📝 WalkthroughWalkthroughThe PR removes desktop memory telemetry and relay-socket outage telemetry, including their implementations, exports, integrations, socket naming, and dedicated tests. Core relay-socket connection and reconnection behavior remains. ChangesRelay-socket telemetry removal
Desktop memory telemetry removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 4 individual chapters for you:
Chapters generated by Stage for commit 7695131 on Jul 26, 2026 6:44am UTC. |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
What
Removes two high-volume PostHog telemetry pipelines:
resource_snapshot, SUPER-1550) — the every-5-minute desktop memory sampler. At partial rollout it is already ~500k events/day (~2M/week, instantly the Bump react from 18.3.1 to 19.2.0 #3 event in the project); at full fleet adoption it projects to ~1.4M/day on a ~1.3M/day baseline, i.e. a 2x of total ingestion, decoupled from actual usage (desktops idling all weekend keep emitting).relay_ws_degraded/relay_ws_recovered/relay_ws_access_deniedoutage telemetry from feat(workspace-client,desktop): relay WS outage telemetry + version-stamped desktop events #5653 (renderer PostHog sink,outageReportermodule, and the telemetry-onlynameoption oncreateRelaySocket). ~97k events last week. The version-stamped desktop events from feat(workspace-client,desktop): relay WS outage telemetry + version-stamped desktop events #5653 (app_versionregister) are kept.Why
These are machine-cadence events, not user actions — they inflate PostHog ingestion volume without corresponding product signal.
Verification
bun run typecheck: 35/35 tasks passpackages/workspace-clientrelaySocket tests: 4 pass; desktopterminal-ws-transporttests: 15 passNote: existing 1.17.x installs keep emitting both event families until they update to a release containing this change.
Summary by cubic
Remove desktop memory
resource_snapshotsampler and relay WebSocket outage telemetry (relay_ws_*) to cut PostHog ingestion and focus on user-signal events. Addresses SUPER-1550 by removing machine-cadence pipelines that doubled ingestion without product value.Refactors
startMemoryTelemetry/stopMemoryTelemetrycalls (no moreresource_snapshot).relay_ws_*events frompackages/workspace-client; droppedsetRelaySocketTelemetryand related tests.namefromcreateRelaySocket; updated desktop/web callers.app_versionidentify properties.Migration
setRelaySocketTelemetryandRelaySocketTelemetryEvent; these are no longer exported from@superset/workspace-client.nameoption when callingcreateRelaySocket.Written for commit 7695131. Summary will update on new commits.
Summary by CodeRabbit
Removed Telemetry
Connection Handling
Maintenance