Skip to content

refactor(chat): drop Superset MCP tools from v1 chat runtime - #6031

Merged
saddlepaddle merged 1 commit into
mainfrom
mcp-rework/0d-chat-drop-mcp
Jul 31, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
mcp-rework/0d-chat-drop-mcp

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Part of the MCP v2 rework (Phase 0d) — this starts the v1 MCP sunset clock: v1 chat was the last internal consumer of the deprecated /api/agent/mcp endpoint.

  • Deletes getSupersetMcpTools (Mastra MCP client pointed at v1) and its only call site in the chat runtime. This matches v2 chat, which deliberately dropped Superset MCP tools (plans/v1-to-v2-fast-migration.md).
  • Fixes .superset/lib/setup/steps.sh to write the v2 MCP URL into locally provisioned .mcp.json files — it was still writing the v1 path while every checked-in agent config (opencode.json, .codex/config.toml, .mastracode/mcp.json) already uses v2.

Remaining v1 removal (server package + route) lands separately after the deprecation window + traffic check.

https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2


Open in Stage

Summary by cubic

Drops Superset MCP tool integration from the v1 chat runtime and updates local setup to use the v2 MCP endpoint, removing the last dependency on the deprecated /api/agent/mcp. Aligns v1 chat with v2 and starts the v1 MCP sunset.

  • Refactors

    • Remove getSupersetMcpTools and its only call site in packages/chat/src/server/trpc/service.ts.
    • Delete packages/chat/src/server/trpc/utils/runtime/superset-mcp.ts.
  • Bug Fixes

    • Update .superset/lib/setup/steps.sh to write http://localhost:<port>/api/v2/agent/mcp into local .mcp.json.

Written for commit 0f7e61f. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Updated local MCP server connectivity to use the current API v2 endpoint.
    • Improved chat runtime setup by removing an outdated MCP tool-loading path, helping ensure more reliable session initialization.
    • Preserved existing runtime lifecycle and chat routing behavior while simplifying tool availability handling.

v2 chat deliberately dropped Superset MCP tools; v1 chat was the last
internal consumer of the deprecated /api/agent/mcp endpoint. Also
points the local dev setup script at the v2 MCP URL — every checked-in
agent config already uses v2.

Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
@ghost

ghost commented Jul 28, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Remove Superset MCP v1 tools from chat runtime
2 Update local setup to use MCP v2 endpoint
Open in Stage

Chapters generated by Stage for commit 0f7e61f on Jul 28, 2026 10:16pm UTC.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d78b60c-9d12-4146-af8b-6a1124a3b410

📥 Commits

Reviewing files that changed from the base of the PR and between 168687b and 0f7e61f.

📒 Files selected for processing (3)
  • .superset/lib/setup/steps.sh
  • packages/chat/src/server/trpc/service.ts
  • packages/chat/src/server/trpc/utils/runtime/superset-mcp.ts
💤 Files with no reviewable changes (2)
  • packages/chat/src/server/trpc/utils/runtime/superset-mcp.ts
  • packages/chat/src/server/trpc/service.ts

📝 Walkthrough

Walkthrough

The local MCP setup URL now targets /api/v2/agent/mcp. Chat runtime creation no longer loads or passes Superset MCP tools, and the associated helper implementation was removed.

Changes

MCP integration alignment

Layer / File(s) Summary
Remove runtime MCP tool loading
packages/chat/src/server/trpc/service.ts, packages/chat/src/server/trpc/utils/runtime/superset-mcp.ts
Chat runtime creation no longer imports or supplies dynamically loaded Superset MCP tools; the helper implementation was removed.
Update local MCP endpoint
.superset/lib/setup/steps.sh
Local MCP setup now uses /api/v2/agent/mcp on the configured API port.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: snehendu098

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but it omits the required How I tested it section and checklist items from the template. Add the required What & why, How I tested it, and Checklist sections, including the template checkboxes and any validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately summarizes the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mcp-rework/0d-chat-drop-mcp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 4d98572 into main Jul 31, 2026
18 checks passed
@saddlepaddle
saddlepaddle deleted the mcp-rework/0d-chat-drop-mcp branch July 31, 2026 23:45

This branch was previously deployed

1 inactive deployment
preview — 0f7e61f3 Deployed Jul 28, 2026 by saddlepaddle via Deploy Admin #6915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant