Repository navigation
fix(mobile): hide project sections with no workspaces - #6516
Conversation
An empty section was justified while the header carried a create button; once that came out it was a row that said nothing and did nothing. Starting work in an empty project goes through the composer's project picker, which lists every project regardless. Also fixes the header's VoiceOver label reading "1 workspaces".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe home screen now omits project sections without workspaces in all modes. Section accessibility labels now use singular or plural workspace wording based on the count. ChangesHome section updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change hides empty project sections and corrects the workspace count label without affecting project creation; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
What & why
Project sections with no workspaces were being rendered — a header, a name and a
0,introducing nothing.
Showing them was a deliberate call in the original design, but the reasoning was "a project
with nothing in it is exactly where you'd want to start one" — which only held while the
section header carried a
+. That button came out during layout review (it duplicated theper-row
+a row apart, at the same size and colour), and the justification left with it.Nothing replaced it, so an empty section became a row that says nothing and does nothing.
Starting work in an empty project still works: the composer's project picker lists every
project on the host regardless of whether it has workspaces.
Also fixes the section header's VoiceOver label, which read "1 workspaces".
How I tested it
On the simulator against a live host: the account has a project with zero workspaces
(
MASTRA-SUPERSET). Before, it occupied a section; after, the list renders six sections andevery one has work in it — confirmed by dumping the accessibility tree rather than eyeballing
it, since the section that mattered was below the fold.
Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)Summary by cubic
Hide empty project sections on the mobile Home list and fix the header’s VoiceOver label. Previously we rendered empty sections (except during search); now we never render them and we say “1 workspace” when count is 1.
workspaces.length === 0(was only filtered during search).Written for commit 9467be9. Summary will update on new commits.
Summary by CodeRabbit