Skip to content

fix(mobile): hide project sections with no workspaces - #6516

Merged
saddlepaddle merged 1 commit into
mainfrom
mobile-hide-empty-projects
Aug 16, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
mobile-hide-empty-projects

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 15, 2026 •

Copy link
Copy Markdown
Collaborator

What & why

Project sections with no workspaces were being rendered — a header, a name and a 0,
introducing nothing.

Showing them was a deliberate call in the original design, but the reasoning was "a project
with nothing in it is exactly where you'd want to start one"
— which only held while the
section header carried a +. That button came out during layout review (it duplicated the
per-row + a row apart, at the same size and colour), and the justification left with it.
Nothing replaced it, so an empty section became a row that says nothing and does nothing.

Starting work in an empty project still works: the composer's project picker lists every
project on the host regardless of whether it has workspaces.

Also fixes the section header's VoiceOver label, which read "1 workspaces".

How I tested it

On the simulator against a live host: the account has a project with zero workspaces
(MASTRA-SUPERSET). Before, it occupied a section; after, the list renders six sections and
every one has work in it — confirmed by dumping the accessibility tree rather than eyeballing
it, since the section that mattered was below the fold.

"Boid Home, 1 workspace"          "notion-clone, 1 workspace"
"Superset, 14 workspaces"         "presentations, 1 workspace"
"evidence, 1 workspace"           "frontend-interview, 1 workspace"

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs

Summary by cubic

Hide empty project sections on the mobile Home list and fix the header’s VoiceOver label. Previously we rendered empty sections (except during search); now we never render them and we say “1 workspace” when count is 1.

  • HomeScreen: always filter out sections where workspaces.length === 0 (was only filtered during search).
  • ProjectSectionHeader: accessibilityLabel pluralizes “workspace(s)” correctly.
  • Starting work in an empty project still goes through the composer’s project picker, which lists all projects.

Written for commit 9467be9. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Empty project sections are now hidden consistently, including when not searching.
    • Improved accessibility labels by using the correct singular or plural wording for workspace counts.

An empty section was justified while the header carried a create button; once
that came out it was a row that said nothing and did nothing. Starting work in
an empty project goes through the composer's project picker, which lists every
project regardless.

Also fixes the header's VoiceOver label reading "1 workspaces".
@coderabbitai

coderabbitai Bot commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 374bc26c-beff-4609-ad49-f1cf2f228121

📥 Commits

Reviewing files that changed from the base of the PR and between c3bb58e and 9467be9.

📒 Files selected for processing (2)
  • apps/mobile/screens/(authenticated)/(home)/home/HomeScreen.tsx
  • apps/mobile/screens/(authenticated)/(home)/home/components/ProjectSectionHeader/ProjectSectionHeader.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The home screen now omits project sections without workspaces in all modes. Section accessibility labels now use singular or plural workspace wording based on the count.

Changes

Home section updates

Layer / File(s) Summary
Section filtering and accessibility labels
apps/mobile/screens/(authenticated)/(home)/home/HomeScreen.tsx, apps/mobile/screens/(authenticated)/(home)/home/components/ProjectSectionHeader/ProjectSectionHeader.tsx
The home screen omits empty project sections in all modes. The section header uses “workspace” for one workspace and “workspaces” otherwise.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 9467b

The change hides empty project sections and corrects the workspace count label without affecting project creation; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: kitenite

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the change, rationale, testing, and checklist status; the maintainer-access item is unchecked but applies only to fork PRs.
Title check ✅ Passed The title uses conventional commit format and clearly describes hiding mobile project sections with no workspaces.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mobile-hide-empty-projects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit e2bc541 into main Aug 16, 2026
19 checks passed

This branch was previously deployed

1 inactive deployment
preview — 9467be9f Deployed Aug 15, 2026 by saddlepaddle via Deploy Admin #7806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant