Skip to content

feat(desktop): let users dismiss the new-workspace sample prompts - #6540

Merged
Kitenite merged 3 commits into
mainfrom
new-workspace-dismiss-samples
Aug 16, 2026
Merged

Kitenite merged 3 commits into
mainfrom
new-workspace-dismiss-samples

Conversation

@Kitenite

@Kitenite Kitenite commented Aug 16, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Adds a hover-reveal ✕ to the sample-prompt suggestions on the new-workspace screen (both experiment arms — cards tray and rows). Dismissing hides them permanently; the rotating ghost-text placeholder remains as the suggestion surface.

Why / Context

Follow-up to #6537. The template cards target cold-start users, but they render for every user on every empty composer, forever — Codex, by comparison, only shows its template cards until you have task history. Power users get a way to clear them; the analytics keep measuring whether veterans use them at all.

How It Works

  • samplePromptsDismissed boolean on the existing v2-workspace-create-defaults persisted store (already allowlisted in the persisted-key registry; fixed-size singleton, zustand persist shallow-merges the new field to false for existing profiles — no version bump).
  • NewWorkspaceScreen gates the suggestion block on the flag and passes onDismiss to both layouts; dismissal fires new_workspace_sample_prompts_dismissed with the active layout so the cards-vs-rows experiment can account for lost exposure.
  • The ✕ is opacity-0 until container hover (or keyboard focus), so it adds no visual noise.

Manual QA Checklist

Verified live via CDP against the dev desktop:

  • ✕ appears on hover at the tray's top-right, hidden otherwise
  • Clicking it removes the suggestions; composer + ghost text unaffected
  • samplePromptsDismissed: true lands in the persisted store
  • Suggestions stay gone after location.reload()
  • Persisted-key registry tests pass (no unregistered writer)

Testing

  • bun run typecheck
  • biome check on touched files
  • bun test src/renderer/lib/persisted-keys

Known Limitations

  • No un-dismiss UI yet — deliberate until the dismissal-rate data says whether anyone wants them back (a Settings → Behavior toggle is the natural home if so).

Summary by cubic

Let users dismiss sample prompt suggestions on the new-workspace screen. Previously they showed on every empty composer; now a hover-reveal X hides them permanently while the rotating ghost-text placeholder remains. The sample-card container is removed so cards float directly on the canvas.

Review notes

  • Persist samplePromptsDismissed in v2-workspace-create-defaults (default false; shallow-merged for existing profiles). No migration.
  • Gate suggestions on this flag in both layouts; pass onDismiss through SamplePromptCards and SamplePrompts; show the close button on hover/focus only.
  • Track new_workspace_sample_prompts_dismissed with the active layout to account for lost exposure.

Written for commit 5086ed2. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added the ability to dismiss sample prompt suggestions when creating a workspace.
    • Dismissal preferences are saved and persist across sessions.
    • Added accessible dismiss controls that appear on hover or keyboard focus.
    • Sample prompts now hide after dismissal and only appear when relevant.

The suggestion cards target cold-start users but rendered for everyone on
every empty composer, forever. A hover-reveal close button on both
layouts (cards tray + rows) persists a samplePromptsDismissed flag in the
existing v2-workspace-create-defaults store; the rotating ghost text
remains as the suggestion surface. Dismissal is tracked so the
prompt-cards experiment can account for lost exposure.
@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6e90f4f-03b3-47ee-8b16-526dd85b0493

📥 Commits

Reviewing files that changed from the base of the PR and between f0b9064 and 5086ed2.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/components/SamplePromptCards/SamplePromptCards.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/components/SamplePromptCards/SamplePromptCards.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Sample prompt cards and rows now expose accessible dismiss controls. NewWorkspaceScreen persists dismissal state and suppresses prompts after dismissal.

Sample prompt dismissal

Layer / File(s) Summary
Persisted dismissal state and flow
apps/desktop/src/renderer/stores/v2-workspace-create-defaults.ts, apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/NewWorkspaceScreen.tsx
The store persists samplePromptsDismissed. NewWorkspaceScreen records the active layout and updates the store.
Dismiss controls and prompt wiring
apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/components/SamplePromptCards/SamplePromptCards.tsx, apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/components/SamplePrompts/SamplePrompts.tsx, apps/desktop/src/renderer/routes/_authenticated/components/DashboardNewWorkspaceModal/components/NewWorkspaceScreen/NewWorkspaceScreen.tsx
Both prompt layouts render accessible X-icon dismiss buttons. NewWorkspaceScreen passes the dismissal callback and hides dismissed prompts.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5086e

This localized change lets users permanently dismiss new-workspace sample prompts while preserving the composer and ghost-text experience; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant PromptLayout
  participant NewWorkspaceScreen
  participant WorkspaceCreateDefaultsStore
  PromptLayout->>NewWorkspaceScreen: invoke onDismiss
  NewWorkspaceScreen->>WorkspaceCreateDefaultsStore: setSamplePromptsDismissed(true)
  WorkspaceCreateDefaultsStore-->>NewWorkspaceScreen: persist dismissal state
  NewWorkspaceScreen->>PromptLayout: stop rendering prompts
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses conventional commit format and clearly describes the primary change: allowing users to dismiss new-workspace sample prompts.
Description check ✅ Passed The description explains what changed, why it changed, how it works, and how it was tested, with QA results and limitations.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-workspace-dismiss-samples

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kitenite
Kitenite merged commit a3e82ab into main Aug 16, 2026
12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

saddlepaddle added a commit that referenced this pull request Aug 17, 2026
…6556)

Reworks the new-workspace sample prompts so the prompt-cards experiment
measures form factor and nothing else, and adds a third arm to test whether
four cards cost more than they earn.

The experiment (PostHog 419092) never launched — still draft, flag inactive,
and all 639 flag evaluations since desktop-v1.22.0 returned null, so nobody
was ever bucketed. That left the shipped code free to drift from the
pre-registered design: control grew from three fixed rows to four shuffled
ones, the test arm from two bordered cards to four borderless ones, and only
the cards arm applied the setup-first rule — so the arms differed in content,
not just form factor.

Validating the premises first: the setup prompt takes 69.5% of clicks (not
75%) but always renders first, so share and position are confounded. Setup
clickers create ~3x more workspaces on medians with only 12.7% predating the
click, but the cold-start cell is n=17 and the least-clicked prompt shows the
highest count — a selection signature. Eligible population is ~840 new
accounts/week at a stable 13.5-14.1% click rate, so activation cannot resolve
a realistic form-factor effect in under ~10 weeks while click rate resolves a
large one in ~2-3 weeks across three arms. Click rate becomes primary.

Arms are control (3 rows) / cards2 / cards4, sliced as nested prefixes of one
fixed pool. Selection moved into a shared hook so the setup-first rule and its
pending gate apply identically everywhere — previously cards held for the
setup query while rows rendered immediately, a timing difference the
experiment would have read as a layout effect.

Prompts also split into two tiers keyed on whether the user has a non-main
workspace, the same signal that gates the dismiss affordance: first-run keeps
orientation, returning swaps it for work that assumes they have seen an agent
run, led by a new explain-superset prompt. The tier rides on the click event
so the mediator can be split rather than pooled.

Kept from #6537/#6540: the expanded pool, per-card icons, the agent logo
cluster, and the labeled model/effort pills. The card border is restored,
since prominence is the manipulation under test. The shuffle is dropped, and
dismissal is gated behind the first real workspace — it permanently removes
the surface being measured, and asymmetric dismissal would bias the primary
metric toward null.

Not launchable until a desktop build carrying this ships and the flag's
created_at cutoff is bumped to that build's publish time; old builds map the
new variant keys to control.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant