Skip to content

fix(mobile): move home search in-page — iOS 26 header search bar swallows all touches - #6659

Merged
saddlepaddle merged 1 commit into
mainfrom
spectacled-oriole
Aug 19, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
spectacled-oriole

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 19, 2026 •

Copy link
Copy Markdown
Collaborator

What

Search results on mobile home couldn't be tapped, and active search couldn't be dismissed. This replaces the native header Stack.SearchBar with an in-page search field (the BranchPickerScreen pattern) in the home list header. Filtering logic is unchanged.

Why

Reproduced end-to-end on an iOS 26.0 simulator against a local stack: while the UISearchController is active, an invisible native view covers the screen content and eats every touch — instrumented onTouchStart on the list never fired during search, and fired normally once dismissed. Nothing reaches RN, so rows are dead and search feels stuck (only the tiny X escapes).

Tried and failed: obscureBackground={false}, hideNavigationBar both ways, placement variants. No upstream fix through react-native-screens 4.27 / iOS 26.5; adjacent known iOS 26 search regressions: rns #3270 (back nav breaks after search), Apple FB17888632 (stacked search steals touches), rns #3621 (zoom transition blocks touches). The native header search bar is not shippable on iOS 26.

How

  • In-page Input + magnifier glyph as the LegendList header above the scope chips (visually near-identical to the native bar), clearButtonMode="always", returnKeyType="search", autocapitalize/autocorrect off
  • keyboardShouldPersistTaps="handled" + keyboardDismissMode="on-drag" on the list
  • Removed the now-unused Stack/THEME imports

Verified

On-device (iPhone Air sim, iOS 26.0, local API/relay/host-service + seeded workspaces): type → list filters live with result count; tap result → workspace opens; back → query retained; clear (x) → full list restores; scroll drops the keyboard.

Known wrinkle (pre-existing, unchanged): with the keyboard up, the first tap on a row dismisses the keyboard and the second opens it — the rows' native Link.Trigger context-menu wrapper takes the first touch outside RN's control.

Checks: lint:fix clean, typecheck clean, sherif clean. bun test: 175 local failures on this branch vs 178 on clean HEAD — identical failure set (zero unique to this change), all pre-existing local-env noise (pty/git/relay suites).

https://claude.ai/code/session_01JMrgzD2hPpB89caKAxR7ux


Summary by cubic

Moves home search from the native header to an in-page field to restore tap interactions on iOS 26. Old: Stack.SearchBar (UISearchController) swallowed all touches while active; results couldn’t be tapped and search couldn’t dismiss. New: an in-page Input in the list header; taps work, keyboard dismisses on drag, and filtering logic is unchanged.

  • Review notes

    • HomeScreen.tsx: remove header Stack.SearchBar; add listHeader with Input + Search icon above scope chips; set keyboardShouldPersistTaps="handled" and keyboardDismissMode="on-drag".
    • Visual parity with the native bar; clear button always visible. Known pre-existing quirk remains: first tap with keyboard up dismisses it; second opens the row.
  • Rollout

    • No migration required. Focus testing on iOS 26 tap-through and keyboard behavior; quick smoke on Android/earlier iOS.

Written for commit 3e32874. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features

    • Added an in-page search field to the home screen.
    • Added a scope bar alongside the search field for easier browsing.
  • Improvements

    • Improved touch handling and keyboard dismissal while interacting with the home list.

…lows all touches

Activating the native Stack.SearchBar (UISearchController) on iOS 26 lays an
invisible view over the screen content that eats every touch: results can't be
tapped and search won't dismiss. Not fixable via props (obscureBackground,
hideNavigationBar, placement all tried) and unfixed upstream through
react-native-screens 4.27 / iOS 26.5.

Replace it with the app's existing in-page search pattern (BranchPickerScreen):
an Input + magnifier in the list header above the scope chips, always-visible
clear button, keyboard dismissed on drag, taps delivered with the keyboard up.
Filtering logic unchanged.

Claude-Session: https://claude.ai/code/session_01JMrgzD2hPpB89caKAxR7ux
@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fd20ad1a-151e-4eaa-bf91-4b79d386454a

📥 Commits

Reviewing files that changed from the base of the PR and between 2864fc3 and 3e32874.

📒 Files selected for processing (1)
  • apps/mobile/screens/(authenticated)/(home)/home/HomeScreen.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

HomeScreen replaces the native Expo Router search bar with an in-page workspace search input. The list header now contains the search input and scope bar, with keyboard dismissal and handled child taps enabled.

Changes

Workspace search

Layer / File(s) Summary
In-page search header
apps/mobile/screens/(authenticated)/(home)/home/HomeScreen.tsx
Adds a rounded workspace search input with search state binding, search icon, and clear behavior. Keeps the scope bar in the list header. Removes native search-bar configuration and enables keyboard dismissal during list scrolling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 3e328

This change moves mobile home search into the page to restore result taps and keyboard dismissal on iOS 26 while preserving filtering behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: kitenite

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly identifies the main mobile search change and the iOS 26 touch issue.
Description check ✅ Passed The description explains what changed, why it changed, how it was tested, known limitations, and verification results.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spectacled-oriole

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 106dd52 into main Aug 19, 2026
20 checks passed
saddlepaddle added a commit that referenced this pull request Aug 28, 2026
…h bar (#6937)

The in-page pill from #6659 was the workaround for a UISearchController on
the root screen swallowing every touch on iOS 26. A formSheet gives the
search bar its own presentation context: on the sheet's own header the
same controller activates properly (field shrinks, glass cancel button)
and results stay tappable.

- Home: a native magnifying-glass toolbar button opens /search; the pill
  and its filtering plumbing are gone. Hidden while the selected host is
  offline, like the list it searched.
- Search sheet: Stack.SearchBar (stacked, always visible) over a FlatList
  with automatic insets; same matching and pin/recency ordering as before,
  scoped to the active host or Cloud. Tapping a result closes the sheet,
  then pushes the workspace.
- autoFocus is Android-only in react-native-screens, so the bar is focused
  through its ref when the presentation's transitionEnd fires.

Claude-Session: https://claude.ai/code/session_01Ck1GRWn2c2mjHBE3e2yaZ1

This branch was previously deployed

1 inactive deployment
preview — 3e32874d Deployed Aug 19, 2026 by saddlepaddle via Deploy Docs #8112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant