Repository navigation
fix(mobile): move home search in-page — iOS 26 header search bar swallows all touches - #6659
Conversation
…lows all touches Activating the native Stack.SearchBar (UISearchController) on iOS 26 lays an invisible view over the screen content that eats every touch: results can't be tapped and search won't dismiss. Not fixable via props (obscureBackground, hideNavigationBar, placement all tried) and unfixed upstream through react-native-screens 4.27 / iOS 26.5. Replace it with the app's existing in-page search pattern (BranchPickerScreen): an Input + magnifier in the list header above the scope chips, always-visible clear button, keyboard dismissed on drag, taps delivered with the keyboard up. Filtering logic unchanged. Claude-Session: https://claude.ai/code/session_01JMrgzD2hPpB89caKAxR7ux
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthrough
ChangesWorkspace search
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change moves mobile home search into the page to restore result taps and keyboard dismissal on iOS 26 while preserving filtering behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…h bar (#6937) The in-page pill from #6659 was the workaround for a UISearchController on the root screen swallowing every touch on iOS 26. A formSheet gives the search bar its own presentation context: on the sheet's own header the same controller activates properly (field shrinks, glass cancel button) and results stay tappable. - Home: a native magnifying-glass toolbar button opens /search; the pill and its filtering plumbing are gone. Hidden while the selected host is offline, like the list it searched. - Search sheet: Stack.SearchBar (stacked, always visible) over a FlatList with automatic insets; same matching and pin/recency ordering as before, scoped to the active host or Cloud. Tapping a result closes the sheet, then pushes the workspace. - autoFocus is Android-only in react-native-screens, so the bar is focused through its ref when the presentation's transitionEnd fires. Claude-Session: https://claude.ai/code/session_01Ck1GRWn2c2mjHBE3e2yaZ1
What
Search results on mobile home couldn't be tapped, and active search couldn't be dismissed. This replaces the native header
Stack.SearchBarwith an in-page search field (the BranchPickerScreen pattern) in the home list header. Filtering logic is unchanged.Why
Reproduced end-to-end on an iOS 26.0 simulator against a local stack: while the
UISearchControlleris active, an invisible native view covers the screen content and eats every touch — instrumentedonTouchStarton the list never fired during search, and fired normally once dismissed. Nothing reaches RN, so rows are dead and search feels stuck (only the tiny X escapes).Tried and failed:
obscureBackground={false},hideNavigationBarboth ways, placement variants. No upstream fix through react-native-screens 4.27 / iOS 26.5; adjacent known iOS 26 search regressions: rns #3270 (back nav breaks after search), Apple FB17888632 (stacked search steals touches), rns #3621 (zoom transition blocks touches). The native header search bar is not shippable on iOS 26.How
Input+ magnifier glyph as the LegendList header above the scope chips (visually near-identical to the native bar),clearButtonMode="always",returnKeyType="search", autocapitalize/autocorrect offkeyboardShouldPersistTaps="handled"+keyboardDismissMode="on-drag"on the listStack/THEMEimportsVerified
On-device (iPhone Air sim, iOS 26.0, local API/relay/host-service + seeded workspaces): type → list filters live with result count; tap result → workspace opens; back → query retained; clear (x) → full list restores; scroll drops the keyboard.
Known wrinkle (pre-existing, unchanged): with the keyboard up, the first tap on a row dismisses the keyboard and the second opens it — the rows' native
Link.Triggercontext-menu wrapper takes the first touch outside RN's control.Checks: lint:fix clean, typecheck clean, sherif clean.
bun test: 175 local failures on this branch vs 178 on clean HEAD — identical failure set (zero unique to this change), all pre-existing local-env noise (pty/git/relay suites).https://claude.ai/code/session_01JMrgzD2hPpB89caKAxR7ux
Summary by cubic
Moves home search from the native header to an in-page field to restore tap interactions on iOS 26. Old:
Stack.SearchBar(UISearchController) swallowed all touches while active; results couldn’t be tapped and search couldn’t dismiss. New: an in-pageInputin the list header; taps work, keyboard dismisses on drag, and filtering logic is unchanged.Review notes
HomeScreen.tsx: remove headerStack.SearchBar; addlistHeaderwithInput+Searchicon above scope chips; setkeyboardShouldPersistTaps="handled"andkeyboardDismissMode="on-drag".Rollout
Written for commit 3e32874. Summary will update on new commits.
Summary by CodeRabbit
New Features
Improvements