Skip to content

feat(desktop): copy GitHub URL from pull request pane header - #7500

Merged
Kitenite merged 1 commit into
mainfrom
copy-github-url
Sep 13, 2026
Merged

Kitenite merged 1 commit into
mainfrom
copy-github-url

Conversation

@Kitenite

@Kitenite Kitenite commented Sep 13, 2026 •

Copy link
Copy Markdown
Member

What & why

Add a copy button beside the expand control in the pull request pane header, so users can copy the PR's GitHub URL without opening GitHub. The button uses the cached PR URL, briefly shows a checkmark after copying, and reports clipboard failures.

How I tested it

  • In this branch's signed-in Electron renderer at localhost:4245, opened workspace PR feat(workspaces): support explicit local workspaces on shared checkouts #7485 through the sidebar and clicked the new copy button. Confirmed the Copied state and clipboard value https://github.com/superset-sh/superset/pull/7485.
  • Captured and reviewed a pane-header screenshot locally.
  • bun run lint, bun run typecheck (39 packages), bun run check:i18n, and bun run check:plugins pass.
  • bun run test stopped in @superset/trpc on environment-variable validation during module loading (273 pass, 1 fail, 1 error). The full suite did not complete.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs (not a fork PR)

Summary by cubic

Adds a copy button beside the expand control in the pull request pane header, so users can copy the PR's GitHub URL without opening GitHub. The button only renders once the URL is loaded, shows a checkmark after copying, and reports clipboard failures with an error toast.

Written for commit a20530e. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added a copy-to-clipboard button for pull request URLs when available.
    • The button provides visual confirmation after copying and displays an error notification if copying fails.
    • Retained the option to open the pull request in the Pull Requests view.

@Kitenite
Kitenite merged commit 96f0db7 into main Sep 13, 2026
11 of 12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a512b4a1-5278-4689-83d1-fcd7da813347

📥 Commits

Reviewing files that changed from the base of the PR and between b5ce317 and a20530e.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/PullRequestPane/components/PullRequestPaneHeaderExtras/PullRequestPaneHeaderExtras.tsx

📝 Walkthrough

Walkthrough

The pull request pane header now fetches the pull request URL and displays a copy button when the URL is available. The button shows copy or check feedback and reports clipboard failures with an error toast. The existing navigation button remains.

Changes

Pull request link copying

Layer / File(s) Summary
Add pull request link actions
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/PullRequestPane/components/PullRequestPaneHeaderExtras/PullRequestPaneHeaderExtras.tsx
The header fetches the pull request URL, copies it to the clipboard when requested, updates the copy icon state, and shows an error toast when copying fails. The existing “Open in Pull Requests” action remains.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copy-github-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant