Repository navigation
fix(desktop): improve terminal overlay UI styling - #790
Conversation
Update terminal overlay UIs (session killed, connection error, session restored) to use the project's Button component and design system instead of hardcoded Tailwind classes, ensuring visual consistency with the rest of the app.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughReplaced the Terminal component's three overlay variants with a centered Card-based UI driven by icons and standardized content ordering; actions now use the Button component and imports updated accordingly. No public API/signature changes. Changes
Sequence Diagram(s)(omitted — UI overlay refactor does not introduce a new multi-component sequential flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove large circular icon backgrounds and use smaller, more subtle icons. Reduce spacing and text sizes for a more compact, unobtrusive overlay that's better suited for terminal context.
- Wrap overlay content in Card component for better visual hierarchy - Reduce overlay opacity from 80% to 50% - Use LuPower icon for killed session instead of X mark - Add descriptive subtitles explaining each state - Shorten button labels (Restart, Retry, Start Shell)
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Buttoncomponent from@superset/uireact-icons(HiXMark, HiExclamationTriangle, LuTerminal)Test plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.