Skip to content

fix(desktop): improve terminal overlay UI styling - #790

Merged
Kitenite merged 3 commits into
mainfrom
start-shell-ui
Jan 17, 2026
Merged

Kitenite merged 3 commits into
mainfrom
start-shell-ui

Conversation

@Kitenite

@Kitenite Kitenite commented Jan 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update terminal overlay UIs to use the project's Button component from @superset/ui
  • Add consistent iconography using react-icons (HiXMark, HiExclamationTriangle, LuTerminal)
  • Apply design system styling (text-foreground, text-muted-foreground, bg-destructive/10, etc.)

Test plan

  • Open a terminal and kill the session — verify "Session killed" overlay styling
  • Disconnect from terminal daemon — verify "Connection error" overlay styling
  • Restart the app with an existing terminal session — verify "Session restored" overlay styling

Summary by CodeRabbit

  • Style
    • Redesigned terminal status overlays into a compact, centered card-style panel with consistent spacing and icon-driven headings for clearer visual hierarchy.
  • New Features
    • Added explicit action buttons for each state: Restart Session, Retry Connection, and Start Shell.
  • Bug Fixes
    • Standardized overlay behavior and content ordering to improve clarity across session killed, connection error, and session restored states.

✏️ Tip: You can customize this high-level summary in your review settings.

Update terminal overlay UIs (session killed, connection error, session
restored) to use the project's Button component and design system instead
of hardcoded Tailwind classes, ensuring visual consistency with the rest
of the app.
@coderabbitai

coderabbitai Bot commented Jan 17, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Replaced the Terminal component's three overlay variants with a centered Card-based UI driven by icons and standardized content ordering; actions now use the Button component and imports updated accordingly. No public API/signature changes.

Changes

Cohort / File(s) Summary
Terminal UI Overlay Enhancement
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx
Replaced three plain overlay UIs with a Card-backed, icon-led layout (icons: HiExclamationTriangle, LuPower, LuTerminal), swapped inline buttons for Button components, standardized content order (icon → title → description → details → primary action), and adjusted action labels and styling.

Sequence Diagram(s)

(omitted — UI overlay refactor does not introduce a new multi-component sequential flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 I nibbled at the terminal's face,
Pasted icons in a cozy place.
Cards and buttons, tidy and small,
Now overlays stand proud and tall.
Hooray — a rabbit’s gentle trace!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: improving terminal overlay UI styling through refactoring with component upgrades and design system integration.
Description check ✅ Passed The description covers the key aspects of the change (Button component adoption, iconography, design system styling) with a concrete test plan, though it omits some template sections like Related Issues and Type of Change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Remove large circular icon backgrounds and use smaller, more subtle icons.
Reduce spacing and text sizes for a more compact, unobtrusive overlay
that's better suited for terminal context.
- Wrap overlay content in Card component for better visual hierarchy
- Reduce overlay opacity from 80% to 50%
- Use LuPower icon for killed session instead of X mark
- Add descriptive subtitles explaining each state
- Shorten button labels (Restart, Retry, Start Shell)
@Kitenite
Kitenite merged commit b4d9639 into main Jan 17, 2026
3 of 5 checks passed
@Kitenite
Kitenite deleted the start-shell-ui branch January 17, 2026 21:49
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant