Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,6 @@ GOOGLE_SEARCH_CONSOLE_SITE_URL=sc-domain:superset.sh
# -----------------------------------------------------------------------------
PLUGIN_CLIENT_METADATA_BASE_URL=

# -----------------------------------------------------------------------------
# Connector OAuth clients
# Only for connectors whose requires_env names a pair that no other feature
# already sets — the rest reuse the integration clients above. Without them the
# connector still lists, but Connect answers "not configured".
# -----------------------------------------------------------------------------
PLUGIN_GITHUB_CLIENT_ID=
PLUGIN_GITHUB_CLIENT_SECRET=

# -----------------------------------------------------------------------------
# Sentry Error Tracking
# -----------------------------------------------------------------------------
Expand Down
9 changes: 0 additions & 9 deletions .env.local.example
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,6 @@ GOOGLE_SEARCH_CONSOLE_SITE_URL=sc-domain:superset.sh
# -----------------------------------------------------------------------------
PLUGIN_CLIENT_METADATA_BASE_URL=

# -----------------------------------------------------------------------------
# Connector OAuth clients
# Only for connectors whose requires_env names a pair that no other feature
# already sets — the rest reuse the integration clients above. Without them the
# connector still lists, but Connect answers "not configured".
# -----------------------------------------------------------------------------
PLUGIN_GITHUB_CLIENT_ID=
PLUGIN_GITHUB_CLIENT_SECRET=

# -----------------------------------------------------------------------------
# Sentry Error Tracking (optional — leave blank to disable)
# -----------------------------------------------------------------------------
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/deploy-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ jobs:
POSTHOG_API_KEY: ${{ secrets.POSTHOG_API_KEY }}
GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT }}
PLUGIN_CLIENT_METADATA_BASE_URL: ${{ secrets.PLUGIN_CLIENT_METADATA_BASE_URL }}
PLUGIN_GITHUB_CLIENT_ID: ${{ secrets.PLUGIN_GITHUB_CLIENT_ID }}
PLUGIN_GITHUB_CLIENT_SECRET: ${{ secrets.PLUGIN_GITHUB_CLIENT_SECRET }}
POSTHOG_PROJECT_ID: ${{ secrets.POSTHOG_PROJECT_ID }}
KV_REST_API_URL: ${{ secrets.KV_REST_API_URL }}
KV_REST_API_TOKEN: ${{ secrets.KV_REST_API_TOKEN }}
Expand Down Expand Up @@ -229,8 +227,6 @@ jobs:
--env POSTHOG_API_KEY=$POSTHOG_API_KEY \
--env GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT="$GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT" \
--env PLUGIN_CLIENT_METADATA_BASE_URL="$PLUGIN_CLIENT_METADATA_BASE_URL" \
--env PLUGIN_GITHUB_CLIENT_ID="$PLUGIN_GITHUB_CLIENT_ID" \
--env PLUGIN_GITHUB_CLIENT_SECRET="$PLUGIN_GITHUB_CLIENT_SECRET" \
--env POSTHOG_PROJECT_ID=$POSTHOG_PROJECT_ID \
--env KV_REST_API_URL=$KV_REST_API_URL \
--env KV_REST_API_TOKEN=$KV_REST_API_TOKEN \
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/deploy-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ jobs:
MERCURY_API_TOKEN: ${{ secrets.MERCURY_API_TOKEN }}
GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT }}
PLUGIN_CLIENT_METADATA_BASE_URL: ${{ secrets.PLUGIN_CLIENT_METADATA_BASE_URL }}
PLUGIN_GITHUB_CLIENT_ID: ${{ secrets.PLUGIN_GITHUB_CLIENT_ID }}
PLUGIN_GITHUB_CLIENT_SECRET: ${{ secrets.PLUGIN_GITHUB_CLIENT_SECRET }}
STRIPE_WEBHOOK_SECRET: ${{ secrets.STRIPE_WEBHOOK_SECRET }}
STRIPE_PRO_MONTHLY_PRICE_ID: ${{ secrets.STRIPE_PRO_MONTHLY_PRICE_ID }}
STRIPE_PRO_YEARLY_PRICE_ID: ${{ secrets.STRIPE_PRO_YEARLY_PRICE_ID }}
Expand Down Expand Up @@ -249,8 +247,6 @@ jobs:
--env MERCURY_API_TOKEN=$MERCURY_API_TOKEN \
--env GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT="$GOOGLE_SEARCH_CONSOLE_SERVICE_ACCOUNT" \
--env PLUGIN_CLIENT_METADATA_BASE_URL="$PLUGIN_CLIENT_METADATA_BASE_URL" \
--env PLUGIN_GITHUB_CLIENT_ID="$PLUGIN_GITHUB_CLIENT_ID" \
--env PLUGIN_GITHUB_CLIENT_SECRET="$PLUGIN_GITHUB_CLIENT_SECRET" \
--env STRIPE_WEBHOOK_SECRET=$STRIPE_WEBHOOK_SECRET \
--env STRIPE_PRO_MONTHLY_PRICE_ID=$STRIPE_PRO_MONTHLY_PRICE_ID \
--env STRIPE_PRO_YEARLY_PRICE_ID=$STRIPE_PRO_YEARLY_PRICE_ID \
Expand Down
5 changes: 1 addition & 4 deletions packages/shared/src/connectors/connectors.json
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,7 @@
"scopes": ["repo", "read:org", "workflow"],
"scope_separator": " ",
"token_request_auth_method": "client_secret_post",
"requires_env": [
"PLUGIN_GITHUB_CLIENT_ID",
"PLUGIN_GITHUB_CLIENT_SECRET"
],
"requires_env": ["GH_APP_CLIENT_ID", "GH_APP_CLIENT_SECRET"],
"identity": {
"url": "https://api.github.com/user",
"method": "GET",
Expand Down
Loading