Repository navigation
Close the header gaps: 48px workspace tab bar, project side header, no drag class in packages/ui - #8023
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughDashboard record layouts now render a side-header area with separate optional title and actions. Page headers support configurable filler styling and conditional window-control spacing. Workspace header elements use updated sizing. ChangesDashboard layout and workspace chrome
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The headers reserve window-control space only on the right, as intended. No merge-blocking issue is established in the reviewed scope. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected changes affect header composition and window-control spacing, without identifying a new privilege or data-access path. Risk remains low rather than minimal because prior-version exposure and broader security coverage are not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| <WindowChromeScope enabled={false}> | ||
| <PageHeader | ||
| className="sticky top-0 z-10 min-w-0 bg-background [grid-area:side-header] @min-[900px]:border-l @min-[900px]:border-border" | ||
| contentClassName={sideTitle ? "pl-5" : "pl-0"} |
There was a problem hiding this comment.
Empty header reduces title space On a narrow Windows or Linux project page, the new side header has no visible title or actions, but its
PageHeader still reserves space for the window controls. The main header reserves that space too, so the project name truncates sooner than it did when the header spanned the full row.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx
Line: 32-35
Comment:
**Empty header reduces title space** On a narrow Windows or Linux project page, the new side header has no visible title or actions, but its `PageHeader` still reserves space for the window controls. The main header reserves that space too, so the project name truncates sooner than it did when the header spanned the full row.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
No issues found across 11 files
Architecture diagram
sequenceDiagram
participant Client as Client (Desktop/Web)
participant RL as RecordLayout
participant PH as PageHeader (packages/ui)
participant TB as TabBar (packages/panes)
participant PR as PRActionHeader
participant WV as WorkspaceView (v2-workspace)
participant PV as ProjectRecordView
participant PPS as ProjectRecordSide
participant CWS as CloudWorkspaceRecordView
participant TKV as TaskRecordView
Note over Client,RL: Record Page Layout (Task, Workspace, Project)
Client->>RL: Render record page
RL->>RL: Compute grid layout (header + side-header always present)
alt Task or Cloud Workspace record
RL->>TKV: Provide sideActions
RL->>CWS: Provide sideActions
else Project record
RL->>PV: Provide sideTitle="Properties"
PV->>PPS: Pass titleClassName for responsive hide
end
RL->>PH: Render main header row (start, end)
RL->>PH: Render side header row (sideTitle or sideActions)
Note over PH: Side header row
alt sideTitle provided (project)
PH->>PH: Show title (hidden below 900px)
end
PH->>PH: Render filler (drag region or plain spacer)
PH->>PH: Render sideActions (task/workspace actions)
Note over WV: Workspace tab bar (right panel)
Client->>WV: Open workspace route
WV->>TB: Render 48px tab bar
WV->>PR: Render actions strip (48px)
PR->>PR: Match tab bar height
Note over PH,WV: Header height consistency
Client->>PH: Configure fillerClassName
alt Desktop app
PH->>PH: Use drag class for window dragging
else Web app
PH->>PH: Use plain spacer
end
Note over Client,RL: Responsive behavior
alt Wide window (>= 900px)
RL->>RL: Side column shows header row with title/actions
PPS->>PPS: Hide "Properties" heading (moved to header row)
else Narrow window
RL->>RL: Side column below main content
PPS->>PPS: Show "Properties" heading in side column
end
Note over RL,PPS: Collapsed rail behavior
Client->>RL: Sidebar collapsed state
RL->>RL: Rail header matches global 48px height (no special case)
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…r, and no drag class in packages/ui The workspace tab bar and the right panel's top strip go from 40px to 48px, so every top row in the app is one height and the collapsed rail's strip needs no workspace special case. Every record page now has a side header row: actions on the right (task, workspace) or a title on the left (project, whose Properties heading moves up into it on wide windows), so the collapsed band spans the whole row and the no-side-header mode and its drag strip go away. The shared page title bar takes a fillerClassName instead of hardcoding the desktop's drag class.
PageHeader reserved the window-controls width in every header, so a record page's main header
and the pull request list pane (beside the detail pane) each wasted ~97px mid-row on
Windows/Linux and truncated their titles early. They now pass reservesWindowControls={false}
(the list pane only while the detail pane shows).
028577d to
9e3c0a7
Compare
…8057) * fix(desktop): move the ship controls back into the workspace tab bar Reverses #7958. The Changes/PR control and the open-in button return to the pane tab bar's trailing slot, before the sidebar toggle, so they stay reachable while the right sidebar is closed. The sidebar's top strip is back to Pages and Run. - Closing Changes takes the sidebar down with it again when the sidebar is on the Changes tab; getWorkspaceSidebarTab and its test return. - The strip keeps its 48px height from #8023 and still sizes the Run hotkey hint off the strip width. Co-Authored-By: Claude <noreply@anthropic.com> * test(host-service): drop the parallel workspace.create probe It raced two worktree adds against git itself and failed on unrelated PRs with "failed to read .git/worktrees/a/commondir". Its own note said to retire it once it started failing. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Closes the three known gaps left after #7964 and #8002. Screenshots: https://app.superset.sh/page/header-gaps-closed-lv8cnx
packages/panesTabBar). The right panel's top strip (PRActionHeader) moves with it, so every top row in the app is one height. The collapsed rail's strip no longer needs a special case for the workspace route: it's the same band everywhere. This is the one visible change, an 8px taller tab row.RecordLayouttakessideActions(task, cloud workspace) orsideTitle(project). The project's "Properties" heading moves up into that row on wide windows and stays in the side column on narrow ones. The collapsed band spans the whole top row, and nothing shifts between sidebar states. The "no side header" grid mode and its separate drag strip are gone.packages/uipage title bar takes afillerClassNameinstead of hardcoding the desktop'sdragclass. Desktop passesdrag; the web app gets a plain spacer.Verified (dev app, CDP)
Summary by cubic
Closes the three remaining header gaps: makes the workspace tab bar 48px tall, gives every record page a side header row, and removes the hardcoded
dragclass frompackages/ui.packages/ui's page title bar takes afillerClassNameinstead of hardcoding the desktop'sdragclass; desktop passesdrag, the web app gets a plain spacer.Written for commit 9e3c0a7. Summary will update on new commits.
Summary by CodeRabbit