Skip to content

Close the header gaps: 48px workspace tab bar, project side header, no drag class in packages/ui - #8023

Merged
saddlepaddle merged 2 commits into
mainfrom
saddlepaddle/close-header-gaps
Oct 1, 2026
Merged

saddlepaddle merged 2 commits into
mainfrom
saddlepaddle/close-header-gaps

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Closes the three known gaps left after #7964 and #8002. Screenshots: https://app.superset.sh/page/header-gaps-closed-lv8cnx

  • Workspace tab bar 40px → 48px (packages/panes TabBar). The right panel's top strip (PRActionHeader) moves with it, so every top row in the app is one height. The collapsed rail's strip no longer needs a special case for the workspace route: it's the same band everywhere. This is the one visible change, an 8px taller tab row.
  • Every record page has a side header row. RecordLayout takes sideActions (task, cloud workspace) or sideTitle (project). The project's "Properties" heading moves up into that row on wide windows and stays in the side column on narrow ones. The collapsed band spans the whole top row, and nothing shifts between sidebar states. The "no side header" grid mode and its separate drag strip are gone.
  • packages/ui page title bar takes a fillerClassName instead of hardcoding the desktop's drag class. Desktop passes drag; the web app gets a plain spacer.

Verified (dev app, CDP)

  • All 36 screen × sidebar-state rows: window controls at x 88/122/150, y 23 in both states; every header 48px, now including the workspace tab bar (measured 48 in both states); drag regions clean; no new console errors.
  • Project page: Properties is centered in the side header row on wide windows. At 800px the header copy is hidden and the side column shows its own heading.
  • Checks: lint, i18n, typecheck (desktop, ui, panes), 6,291 desktop renderer tests and 114 panes tests pass.

Summary by cubic

Closes the three remaining header gaps: makes the workspace tab bar 48px tall, gives every record page a side header row, and removes the hardcoded drag class from packages/ui.

  • The workspace tab bar and the right panel's top strip go from 40px to 48px, so every top row in the app is one height and the collapsed rail no longer needs a workspace-route special case. The 8px taller tab row is the only visible change.
  • Record pages always render a side header row — actions on the right for task and workspace pages, a title on the left for projects. On wide windows the project's "Properties" heading moves into that row; on narrow windows it stays in the side column.
  • The previous no-side-header grid mode and its separate drag strip are gone.
  • packages/ui's page title bar takes a fillerClassName instead of hardcoding the desktop's drag class; desktop passes drag, the web app gets a plain spacer.
  • Headers that sit beside another header no longer reserve the Windows/Linux window-controls width, so record pages and the pull-request list pane stop wasting ~97px mid-row.

Written for commit 9e3c0a7. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • UI Improvements
    • Record pages now use a consistent side-panel header, with titles and actions arranged separately. Project properties and cloud workspace and task actions appear in the side panel.
    • Project properties headings adapt to screen width, staying hidden on wider screens.
    • Workspace tab bars and pull request action headers are taller.
    • Page headers support styling the space between the title and actions; loaded pages retain a draggable area there.
    • The collapsed workspace sidebar now uses consistent top spacing, and pull request headers reserve space for window controls based on the detail pane’s state.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 293660f6-c08a-4943-ab67-c6cef892d74c

📥 Commits

Reviewing files that changed from the base of the PR and between 028577d and 9e3c0a7.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 11033e17-0719-43c3-bf65-9d55a3f2caf6

📥 Commits

Reviewing files that changed from the base of the PR and between 3221600 and 028577d.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/PageHeader/PageHeader.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/pull-requests/components/PullRequestsView/components/PullRequestsTopBar/PullRequestsTopBar.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Dashboard record layouts now render a side-header area with separate optional title and actions. Page headers support configurable filler styling and conditional window-control spacing. Workspace header elements use updated sizing.

Changes

Dashboard layout and workspace chrome

Layer / File(s) Summary
Record side header and integrations
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/cloud-workspaces/$workspaceId/components/CloudWorkspaceRecordView/CloudWorkspaceRecordView.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/components/TaskRecordView/TaskRecordView.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/projects/$projectId/components/ProjectRecordView/ProjectRecordView.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/CloudSection/CloudSection.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/projects/$projectId/components/ProjectRecordView/components/ProjectRecordSide/ProjectRecordSide.tsx
RecordLayout replaces sideHeader with optional sideTitle and sideActions, and always renders a side-header area. Cloud workspace and task actions use sideActions; the project view supplies the “Properties” title. CloudSection accepts a title class, which the project sidebar uses with responsive styling.
Page-header filler and window controls
packages/ui/src/components/PageComments/components/PageHeader/PageHeader.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/PageHeader/PageHeader.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/$slug/components/PageDetailView/PageDetailView.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/pull-requests/components/PullRequestsView/components/PullRequestsTopBar/PullRequestsTopBar.tsx
The UI PageHeader accepts fillerClassName instead of applying the drag class by default; the loaded page supplies that class. The dashboard PageHeader conditionally renders WindowControlsInset, and the pull-request top bar sets the condition from isDetailCollapsed.
Workspace chrome sizing
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/components/PRActionHeader/PRActionHeader.tsx, packages/panes/src/react/components/Workspace/components/TabBar/TabBar.tsx
The collapsed sidebar spacer no longer varies by workspace route and uses h-12 with WINDOW_CHROME_BAND_CLASS. The workspace action header and tab bar heights change from h-10 to h-12.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 02857

The headers reserve window-control space only on the right, as intended. No merge-blocking issue is established in the reviewed scope.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 02857

The inspected changes affect header composition and window-control spacing, without identifying a new privilege or data-access path. Risk remains low rather than minimal because prior-version exposure and broader security coverage are not fully verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The inspected new inputs have renderer-presentation scope. No additional tenant, service, credential, or data-store authority was identified along these input paths; this does not establish complete coverage of surrounding domain actions.

Trust Boundaries and Controls

  • observed — The reusable page header derives owner-facing UI controls from currentUserId and page.createdByUserId. The new fillerClassName is applied only to a spacer, while sharing and deletion remain callback-driven. These are renderer controls, not evidence of server-side authorization.

Resilience and Maintainability Implications

  • observed — The split-view store owns collapse transitions and persistence. Its actions update pane-collapse fields together so collapsing one pane expands the other; the new header consumer only derives spacing from that state and introduces no multi-step operation, cleanup obligation, or recovery transition.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 7.69% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 13 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: the 48px workspace tab bar, project side header, and removal of the hardcoded packages/ui drag class.
Description check ✅ Passed The description explains the changes, motivation, testing performed, screenshots, and reported test results. It does not include the repository checklist section, but the description is otherwise comp…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Adjusts layout spacing and header heights across dashboard views.

The PR appears safe to merge, with a non-blocking narrow-window project-header layout issue.

Findings

  1. P2 Empty header reduces title space ▶
Fix with agent prompt
### Issue 1
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx:32-35
On a narrow Windows or Linux project page, the new side header has no visible title or actions, but its `PageHeader` still reserves space for the window controls. The main header reserves that space too, so the project name truncates sooner than it did when the header spanned the full row.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR aligns the workspace tab bar, right-panel strip, and collapsed rail at 48px; adds a side header to project records; and makes the shared page-title spacer’s drag class opt-in.

  • The new empty project side header unnecessarily reduces main-header space on narrow Windows and Linux windows.

Reviews (1) · Last reviewed commit: "Close the header gaps: a 48px workspace ..."

Comment on lines +32 to +35
<WindowChromeScope enabled={false}>
<PageHeader
className="sticky top-0 z-10 min-w-0 bg-background [grid-area:side-header] @min-[900px]:border-l @min-[900px]:border-border"
contentClassName={sideTitle ? "pl-5" : "pl-0"}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty header reduces title space On a narrow Windows or Linux project page, the new side header has no visible title or actions, but its PageHeader still reserves space for the window controls. The main header reserves that space too, so the project name truncates sooner than it did when the header spanned the full row.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx
Line: 32-35

Comment:
**Empty header reduces title space** On a narrow Windows or Linux project page, the new side header has no visible title or actions, but its `PageHeader` still reserves space for the window controls. The main header reserves that space too, so the project name truncates sooner than it did when the header spanned the full row.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Architecture diagram
sequenceDiagram
    participant Client as Client (Desktop/Web)
    participant RL as RecordLayout
    participant PH as PageHeader (packages/ui)
    participant TB as TabBar (packages/panes)
    participant PR as PRActionHeader
    participant WV as WorkspaceView (v2-workspace)
    participant PV as ProjectRecordView
    participant PPS as ProjectRecordSide
    participant CWS as CloudWorkspaceRecordView
    participant TKV as TaskRecordView

    Note over Client,RL: Record Page Layout (Task, Workspace, Project)

    Client->>RL: Render record page
    RL->>RL: Compute grid layout (header + side-header always present)

    alt Task or Cloud Workspace record
        RL->>TKV: Provide sideActions
        RL->>CWS: Provide sideActions
    else Project record
        RL->>PV: Provide sideTitle="Properties"
        PV->>PPS: Pass titleClassName for responsive hide
    end

    RL->>PH: Render main header row (start, end)
    RL->>PH: Render side header row (sideTitle or sideActions)

    Note over PH: Side header row

    alt sideTitle provided (project)
        PH->>PH: Show title (hidden below 900px)
    end

    PH->>PH: Render filler (drag region or plain spacer)
    PH->>PH: Render sideActions (task/workspace actions)

    Note over WV: Workspace tab bar (right panel)

    Client->>WV: Open workspace route
    WV->>TB: Render 48px tab bar
    WV->>PR: Render actions strip (48px)
    PR->>PR: Match tab bar height

    Note over PH,WV: Header height consistency

    Client->>PH: Configure fillerClassName
    alt Desktop app
        PH->>PH: Use drag class for window dragging
    else Web app
        PH->>PH: Use plain spacer
    end

    Note over Client,RL: Responsive behavior

    alt Wide window (>= 900px)
        RL->>RL: Side column shows header row with title/actions
        PPS->>PPS: Hide "Properties" heading (moved to header row)
    else Narrow window
        RL->>RL: Side column below main content
        PPS->>PPS: Show "Properties" heading in side column
    end

    Note over RL,PPS: Collapsed rail behavior

    Client->>RL: Sidebar collapsed state
    RL->>RL: Rail header matches global 48px height (no special case)
Loading

Re-trigger cubic

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

…r, and no drag class in packages/ui

The workspace tab bar and the right panel's top strip go from 40px to 48px, so every top row
in the app is one height and the collapsed rail's strip needs no workspace special case. Every
record page now has a side header row: actions on the right (task, workspace) or a title on the
left (project, whose Properties heading moves up into it on wide windows), so the collapsed band
spans the whole row and the no-side-header mode and its drag strip go away. The shared page title
bar takes a fillerClassName instead of hardcoding the desktop's drag class.
PageHeader reserved the window-controls width in every header, so a record page's main header
and the pull request list pane (beside the detail pane) each wasted ~97px mid-row on
Windows/Linux and truncated their titles early. They now pass reservesWindowControls={false}
(the list pane only while the detail pane shows).
@saddlepaddle
saddlepaddle force-pushed the saddlepaddle/close-header-gaps branch from 028577d to 9e3c0a7 Compare October 1, 2026 07:47
@saddlepaddle
saddlepaddle merged commit e629b61 into main Oct 1, 2026
20 checks passed
saddlepaddle added a commit that referenced this pull request Oct 2, 2026
…8057)

* fix(desktop): move the ship controls back into the workspace tab bar

Reverses #7958. The Changes/PR control and the open-in button return to
the pane tab bar's trailing slot, before the sidebar toggle, so they stay
reachable while the right sidebar is closed. The sidebar's top strip is
back to Pages and Run.

- Closing Changes takes the sidebar down with it again when the sidebar is
  on the Changes tab; getWorkspaceSidebarTab and its test return.
- The strip keeps its 48px height from #8023 and still sizes the Run
  hotkey hint off the strip width.

Co-Authored-By: Claude <noreply@anthropic.com>

* test(host-service): drop the parallel workspace.create probe

It raced two worktree adds against git itself and failed on unrelated PRs
with "failed to read .git/worktrees/a/commondir". Its own note said to
retire it once it started failing.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
preview — 9e3c0a78 Deployed Oct 1, 2026 by saddlepaddle via Deploy Web #10722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant