Repository navigation
fix(desktop): keep the retired page open action when healing page links - #8154
isaacchacko wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe preference healer now migrates a valid legacy ChangesPage links preference migration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The migration carries valid retired settings into the new page-link tiers, and the suspected click-behavior regression was not present in the applicable legacy code. No actionable merge risk is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to This is a narrowly scoped preference migration that preserves explicit current settings and uses existing link-opening controls. No introduced security failure was established, but concurrent-write recovery and complete URL-validation behavior remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
What & why
Fixes #8153.
#7962 replaced the single
pageOpenActionpreference with apageLinkstier map, but nothing migrated the stored value.healV2UserPreferencesfillspageLinksfrom defaults, so anyone who had customized "Pages" under Browser settings lost it when they updated to 1.33 or later. The old value sits in localStorage and nothing reads it.Now, when a stored row has
pageOpenActionand nopageLinks, the old action becomes the cmd-click tier ofpageLinks. Before #7962 every terminal click on a page link ranpageOpenActionwhatever the modifier. I kept it on cmd-click only, because binding plain click would change what an ordinary click does on every page link. If the old value was the defaultpane, the result equals today's default. OncepageLinksis stored, heal ignores the legacy field.This can't help users who changed any preference after updating. That write persisted
pageLinkswith defaults.How I tested it
schema.test.ts: the legacy value carries over, it's ignored oncepageLinksexists, and an unknown value falls back to defaults. The first fails without the fix.bun teston the file passes (46).biome checkon both files andbun run typecheckin apps/desktop are clean."pageOpenAction": "external"and nopageLinks.No UI change, so no screenshots.
Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)🤖 Generated with Claude Code
Summary by cubic
Fixes #8153, where users who customized the "Pages" open action before 1.33 lost that setting on update because
healV2UserPreferencesnever migrated the retiredpageOpenActionpreference.Bug Fixes
pageOpenActionand nopageLinks, the old action becomes the cmd-click tier ofpageLinks, leaving plain-click behavior unchanged.pageLinksis stored.Written for commit 2d30c9a. Summary will update on new commits.
Summary by CodeRabbit