Repository navigation
Conversation
The Workspaces-page action was renamed to "Show on Sidebar"/"Hide from Sidebar" and the filter to "Sidebar" (Shown/Hidden) in ParadevAI#7000, so "Pin" now only means the pinned section at the top of the sidebar. Update the docs that still pointed users at the old "Pin to Sidebar" label and the old Pinned/Unpinned filter options. Refs ParadevAI#6994 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Project and Device are not in the Filter menu. Since ParadevAI#6901 the device is picked from the page title and projects from their own menu, and Filter holds PR state, Agent, Created by, and Sidebar. The Filter count badge counts only those four. Refs ParadevAI#6994 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
What & why
Refs #6994.
#6994 says "Pin" meant two different things. #7000 fixed the app side: the Workspaces page now says "Show on Sidebar" / "Hide from Sidebar", and the sidebar keeps "Pin" / "Unpin" for the Pinned section.
apps/docs/content/docs/workspaces.mdxstill used the old wording, so this PR updates it:With this, #6994 can be closed.
Not included: the marketing site still says "Pin to Sidebar".
Screenshots
The labels the docs now use, in the dev app:
The sidebar shot was taken on the #8434 branch, so the worktree row shows that PR's fork icon.
How I tested it
Docs only. I checked the wording against the labels on
main:V2WorkspaceContextMenu,V2WorkspacesHeader(Filter menu, device title menu, project menu),v2WorkspacesFilterStore, thev2-workspacesroute search params (device, projects, and the Filter values all sync to the URL), and the sidebar workspace context menu. None of these files changed onmainbetween a8c6da1 and cc31d02.Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too). Lint passes on the merge withmainat cc31d02. I did not run the type check: this PR changes one.mdxfile, which it does not check.Summary by cubic
Aligns the workspaces docs with the current sidebar and Workspaces-page naming, so "Pin" now refers only to the pinned section at the top of the sidebar. The Filter menu is now listed as PR state, Agent, Created by, and Sidebar, with Device and Project moved to the page title and the menu next to Filter. Closes #6994.
Written for commit 89d26a4. Summary will update on new commits.
Summary by CodeRabbit