Repository navigation
fix(mobile): attach files to the cloud workspace before a chat send imports them - #8480
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…mports them A cloud sandbox resolves only files attached to its workspace. The chat send path imported uploads without attaching them first, so sends with attachments into an existing chat on a cloud workspace failed with "Attachment not found". The terminal path already calls cloudWorkspace.attachFiles; the chat path now does the same.
77f4102 to
3447cfa
Compare
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
|
No installed development build can load this pull request as an update: its native fingerprint is |
|
Problem
On a cloud workspace, sending an attachment into an existing ACP chat on mobile fails with "Could not send — Attachment not found".
A cloud sandbox calling
attachment.resolveonly sees files anchored to its own workspace (attachments.parentKind = "cloud_workspace"). The chat send path inWorkspaceScreen.handleSubmituploaded the file and called the host'sattachments.importFromCloudwithout anchoring it first, soresolvefiltered it out.New chats from Home work, because workspace creation anchors the files. Terminal sessions work, because
useWriteTerminalAttachmentscallscloudWorkspace.attachFilesfirst. The chat path came in with #8238 and missed that step.Fix
In a cloud workspace, call
cloudWorkspace.attachFilesbeforeimportFromCloudon a chat send, the same way the terminal path does.Validation
tscreports the same error count before and after (185, none new). This checkout doesn't have the workspace packages built.Summary by cubic
Fixes sending attachments into an existing chat on a cloud workspace, which failed with "Attachment not found" because the cloud sandbox only resolves files attached to its own workspace.
cloudWorkspace.attachFilesbeforeimportFromCloudon chat sends, matching the terminal path.Written for commit 3447cfa. Summary will update on new commits.
Summary by CodeRabbit