Repository navigation
feat(config): .superset/config.toml, dark-launched behind a flag #8795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4,262
−259
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
71beaa0
feat(shared): add project-config module for .superset/config.toml
saddlepaddle 592ee57
feat(host-service): read .superset/config.toml for setup, archive and…
saddlepaddle 4915427
feat(cloud): run [archive] when a cloud workspace is archived
saddlepaddle 534422a
feat(desktop): edit the whole workspace config in Settings
saddlepaddle 65cde6e
feat: convert this repo to config.toml and update docs and prompts
saddlepaddle c6625f4
fix(host-service): only the sandbox's own host-service resolves confi…
saddlepaddle 4a97242
docs(plans): record config.toml v2 outcomes and follow-ups
saddlepaddle 2fc3f94
Merge origin/main into superset/config-toml-v2
saddlepaddle 0e97a4c
fix(desktop): settings search finds the Workspace config section
saddlepaddle af5d233
docs: show the Workspace config editor and how to check setup works
saddlepaddle e3325a8
feat(dev): lease cloud workspace Neon branches for 7 days
saddlepaddle 13e40a9
fix(cloud): cap cloud [archive] at the same 60 seconds as a local arc…
saddlepaddle 18206ad
Merge main into superset/config-toml-v2
saddlepaddle f163c6d
fix(config): address review findings on config.toml
saddlepaddle 25754af
feat(config): put config.toml behind the workspace-config-toml flag
saddlepaddle 65677bd
refactor(config): read v1 through its conversion, so config.toml is t…
saddlepaddle 0a5ab07
Merge remote-tracking branch 'origin/main' into superset/config-toml-v2
saddlepaddle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/usr/bin/env bash | ||
| # Cloud [archive]: deletes this workspace's Neon branch before the box stops. | ||
| # Only that: the box's terminals must keep working if the archive is undone, | ||
| # and setup.cloud.sh creates the branch again on the next boot. | ||
| set -uo pipefail | ||
|
|
||
| SUPERSET_SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| # shellcheck source=/dev/null | ||
| source "$SUPERSET_SCRIPT_DIR/lib/common.sh" | ||
| # shellcheck source=/dev/null | ||
| source "$SUPERSET_SCRIPT_DIR/lib/teardown/steps.sh" | ||
|
|
||
| FAILED_STEPS=() | ||
| SKIPPED_STEPS=() | ||
|
|
||
| step_load_env || step_failed "Load environment variables" | ||
| step_delete_neon_branch || step_failed "Delete Neon branch" | ||
|
|
||
| print_summary "Cloud archive" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # How Superset sets up, runs and archives this repository's workspaces. | ||
| # Reference: apps/docs/content/docs/setup-teardown-scripts.mdx | ||
| # config.json stays until every sandbox runs a host-service that reads this file. | ||
|
|
||
| [setup] | ||
| run = ["./.superset/setup.sh"] | ||
|
|
||
| [setup.cloud] | ||
| run = ["./.superset/setup.cloud.sh"] | ||
|
|
||
| [terminals.dev] | ||
| run = "bun dev" | ||
| default = true | ||
|
|
||
| [terminals.dev.cloud] | ||
| run = "./.superset/dev-stack.cloud.sh" | ||
|
|
||
| [archive] | ||
| run = ["./.superset/teardown.sh"] | ||
|
|
||
| [archive.cloud] | ||
| run = ["./.superset/archive.cloud.sh"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
archive.cloud.shdeletes the Neon branch but leaves.envunchanged. On Undo or a later resume,setup.cloud.shseescloud-${SUPERSET_SANDBOX_WORKSPACE_ID}in that file and returns before recreating the branch. The restored workspace keeps pointing at a deleted database. Clear the setup marker after successful deletion, or make setup check that the branch still exists.Prompt To Fix With AI