Skip to content

chore: remove unused feature flags - #8845

Merged
saddlepaddle merged 2 commits into
mainfrom
saddlepaddle/remove-unused-feature-flags
Oct 24, 2026
Merged

saddlepaddle merged 2 commits into
mainfrom
saddlepaddle/remove-unused-feature-flags

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

What & why

Flags that no longer change anything, removed from the code and deleted in PostHog:

No behavior change for anyone.

Left in place on purpose: mobile-pane (hidden until the superset mobile CLI ships), star-nag-card, and new-workspace-prompt-cards (+ override). Each of those needs a product decision before removal.

How I tested it

  • packages/auth (83) and packages/shared (1444) tests pass. tsc for auth, shared and email shows no errors in the touched files. Biome is clean.
  • git grep finds no other references to the removed constants or getActivationVariant.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Changes
    • Signup notifications are now triggered for every newly created account, rather than only for accounts assigned to a particular experiment variant. As a result, the welcome-email flow no longer varies based on that experiment.

- FEATURE_FLAGS loses CLOUD_ACCESS, DISABLE_REMOTE_AGENT and CHAT_V3.
  Nothing has read them since desktop 1.22.0, 1.21.0 and 1.37.0; chat is
  gated by acp-chat.
- The activation-email gate goes. Experiment 387868 closed in August and
  its flag has been off since, which already sent `user.signed_up` for
  every signup; now the code does so directly.

The flags themselves are deleted in PostHog.

Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b6e82bb2-2325-4e31-9486-bb7d3d6bc188
Commits

Reviewing files that changed from the base of the PR and between 42dc4c8 and 02d289c.

Files selected for processing: 1
  • packages/email/scripts/sync-automations.ts
Files skipped from review as they are similar to previous changes: 1
  • packages/email/scripts/sync-automations.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The auth server now emits user.signed_up for every newly created user. The activation-variant module and three entries in FEATURE_FLAGS were removed. Welcome automation comments were updated.

Changes: Signup welcome event

Layer / File(s) Summary
Emit signup events for all new users
packages/auth/src/lib/lifecycle.ts, packages/auth/src/server.ts, packages/email/scripts/sync-automations.ts
The auth server no longer checks an activation variant before emitting user.signed_up. The activation-variant module was deleted. Related welcome automation comments were updated.

Feature flag constants

Layer / File(s) Summary
Remove feature flag entries
packages/shared/src/constants.ts
CLOUD_ACCESS, DISABLE_REMOTE_AGENT, and CHAT_V3 were removed from FEATURE_FLAGS. MOBILE_VOICE_MODE remains.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: kitenite

Merge Risk: Minimal · up to 02d28

The supplied changes identify no issue that needs resolution before merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "chore: remove unused feature flags" matches the main change. The PR removes the unused FEATURE_FLAGS entries CLOUD_ACCESS, DISABLE_REMOTE_AGENT, and CHAT_V3, plus the activation-email-campa…
Description check Passed The description follows the template well. The "What & why" section explains the removed flags, the reasons they are safe to remove, and the flags kept on purpose, and it states there is no behavior c…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore: remove unused feature flags" matches the main change. The PR removes the unused FEATURE_FLAGS entries CLOUD_ACCESS, DISABLE_REMOTE_AGENT, and CHAT_V3, plus the activation-email-campaign flag and its lifecycle.ts module. It uses conventional commit format. It does not name the auth signup change, but that is secondary to the flag cleanup.

Full details: Description check

Explanation

The description follows the template well. The "What & why" section explains the removed flags, the reasons they are safe to remove, and the flags kept on purpose, and it states there is no behavior change. The "How I tested it" section lists the test runs, type checks, lint, and a git grep check. The checklist is missing. It is not ticked, and the description does not confirm the PR title format, lint/typecheck results beyond Biome, or the fork-maintainer setting. Screenshots are not needed because no user-visible change is claimed. The issue link is not present, but none is required when no issue exists.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The signup email flow changes for every newly created account.

The PR appears safe to merge, with one non-blocking correction to the campaign instructions.

Findings

  1. P2 Campaign instructions describe removed gate ▶
Fix with agent prompt
### Issue 1
packages/auth/src/server.ts:329-331
The signup hook now always sends `user.signed_up`, but `sync-automations.ts:20–24` still says it withholds the event from the experiment's control group and requires a separate event before adding another automation. Update that paragraph too. It could lead future campaign authors to split events unnecessarily.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Removes three unused entries from FEATURE_FLAGS and deletes the activation experiment helper.

  • Every new signup now enters the activation email flow.
  • The shared flag list no longer includes three unused options.

saddlepaddle explicitly identifies the experiment's removal as intentional because it ended and the disabled flag already enrolled every signup.

Reviews (1) · Last reviewed commit: "chore: remove unused feature flags" · Reviewed by Greptile

Comment on lines +329 to +331
try {
const { error } = await resend.events.send({
event: "user.signed_up",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Campaign instructions describe removed gate

The signup hook now always sends user.signed_up, but sync-automations.ts:20–24 still says it withholds the event from the experiment's control group and requires a separate event before adding another automation. Update that paragraph too. It could lead future campaign authors to split events unnecessarily.

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/auth/src/server.ts
Line: 329-331

Comment:
**Campaign instructions describe removed gate**

The signup hook now always sends `user.signed_up`, but `sync-automations.ts:20–24` still says it withholds the event from the experiment's control group and requires a separate event before adding another automation. Update that paragraph too. It could lead future campaign authors to split events unnecessarily.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@expo

expo Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Preview update published for development build db42788c (fingerprint e28b4b490ccc). Open the build on your phone and scan:

Update group 3837d5bd

Co-authored-by: Claude <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
preview — 02d289c7 Deployed Oct 24, 2026 by saddlepaddle via Deploy Docs #12690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant