Skip to content

Revert "fix(connectors): request Autumn rewards scopes" - #9201

Closed
Kitenite wants to merge 1 commit into
mainfrom
kiet/revert-autumn-rewards-scopes
Closed

Kitenite wants to merge 1 commit into
mainfrom
kiet/revert-autumn-rewards-scopes

Conversation

@Kitenite

@Kitenite Kitenite commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Reverts #9176.

Why

Autumn checks requested scopes against our stored dynamic client registration (plugin_oauth_clients), which was registered with the old scope list. Since #9176 deployed, every Autumn connect or reconnect redirects back with:

error=invalid_scope
error_description=The following scopes are invalid: rewards:read, rewards:write

Existing connections keep working, but nobody can connect or reconnect Autumn. This restores connects. A follow-up will update the stored registration when a connector's scopes change, then add the scopes back.

🤖 Generated with Claude Code


Summary by cubic

Reverts the Autumn rewards scopes from #9176 so Autumn connects and reconnects work again.

Autumn validates requested scopes against the stored client registration, which still uses the old scope list, so every connect attempt was rejected with invalid_scope for rewards:read and rewards:write. Existing connections were unaffected. The scopes will be re-added once the stored registration is updated to match.

Written for commit e3991c7. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Permissions
    • The Autumn MCP connection no longer requests access to read or write rewards data during OAuth authorization. Other connection permissions are unchanged.

This reverts commit c9b0dba (#9176).

Autumn validates requested scopes against our stored dynamic client
registration, which was made with the old scope list, so every Autumn
connect now fails with invalid_scope (rewards:read, rewards:write).
Reverting restores connects; the scopes come back once the stored
registration can be updated to match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c4e3bb70-39e4-4042-82d2-fc3055f55a9c
Commits

Reviewing files that changed from the base of the PR and between 9e01258 and e3991c7.

Files selected for processing: 1
  • packages/shared/src/connectors/connectors.json
Files with no reviewable changes: 1
  • packages/shared/src/connectors/connectors.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The Autumn MCP OAuth scope list no longer includes rewards:read or rewards:write.

Changes: Autumn MCP OAuth scopes

Layer / File(s) Summary
Update OAuth scope list
packages/shared/src/connectors/connectors.json
The OAuth scope list removes rewards:read and rewards:write.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: harshithmullapudi

Merge Risk: Minimal · up to e3991

The scope revert is intended to restore Autumn connect and reconnect. No actionable issue is established from the supplied change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "Revert "fix(connectors): request Autumn rewards scopes"" names the main change: reverting the commit that added the Autumn rewards scopes. The diff removes rewards:read and rewards:write fr…
Description check Passed The description explains the reason for the revert. Autumn validates requested scopes against the stored dynamic client registration, which still has the old scope list, so connects and reconnects fai…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Revert "fix(connectors): request Autumn rewards scopes"" names the main change: reverting the commit that added the Autumn rewards scopes. The diff removes rewards:read and rewards:write from the Autumn scope list in packages/shared/src/connectors/connectors.json, which matches the title. The title is specific and follows the conventional-commit subject from the reverted commit.

Full details: Description check

Explanation

The description explains the reason for the revert. Autumn validates requested scopes against the stored dynamic client registration, which still has the old scope list, so connects and reconnects fail with invalid_scope for rewards:read and rewards:write. It also gives the expected outcome and a follow-up plan. It does not follow the template's sections: there is no "What & why" heading with an issue link (it references #9176 instead), and the "How I tested it" section is missing entirely. The checklist items are also absent. The core content is present, so the description is mostly complete, but the missing testing section and checklist are gaps.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This revert appears safe to merge.

Summary

Removes rewards:read and rewards:write from the Autumn connector to restore connects and reconnects.

  • Autumn connect requests leave out the rewards scopes.

Reviews (1) · Last reviewed commit: "Revert "fix(connectors): request Autumn ..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@expo

expo Bot commented Oct 31, 2026

Copy link
Copy Markdown

Preview update published for development build eca66a32 (fingerprint e65ce637d4ee). Open the build on your phone and scan:

Update group 00a1088b

@Kitenite

Copy link
Copy Markdown
Member Author

Closing in favor of fixing forward with #9203.

@Kitenite Kitenite closed this Oct 31, 2026
@Kitenite
Kitenite deleted the kiet/revert-autumn-rewards-scopes branch October 31, 2026 19:53

This branch was previously deployed

1 inactive deployment
preview — e3991c7b Deployed Oct 31, 2026 by Kitenite via Deploy Marketing #13430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant