Repository navigation
fix(desktop): improve workspace removal dialog copy - #923
Conversation
📝 WalkthroughWalkthroughReplace "close" semantics with "hide" in the workspace deletion dialog and adjust dialog controls; add a guard when marking branches as local in getBranches to avoid undefined map access. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change "Close" button to "Hide" and update description to warn about deletion first, then offer hiding as an alternative. Also fix lint warning for non-null assertion in projects.ts.
564cb1b to
ed07fa3
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/components/DeleteWorkspaceDialog/DeleteWorkspaceDialog.tsx (1)
65-82: Align branch dialog copy with new “Hide” messaging
handleClosenow surfaces “Hiding…” / “Workspace hidden”, but the branch-only dialog still labels the action “Close”. This creates inconsistent UX for branch workspaces. Consider renaming the branch dialog title/button (or making toast copy conditional).✅ Suggested alignment (outside this block)
- // For branch workspaces, use simplified dialog (only close option) + // For branch workspaces, use simplified dialog (only hide option) ... - Close workspace "{workspaceName}"? + Hide workspace "{workspaceName}"? ... - This will close the workspace and kill any active terminals. + This will hide the workspace and kill any active terminals. ... - Close + Hide
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Test plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.