Skip to content

feat(desktop): discover Codex models and configure picker visibility - #9236

Draft
Joaco-gavernet wants to merge 1 commit into
ParadevAI:mainfrom
Joaco-gavernet:codex-model-discovery-11b2031e
Draft

Joaco-gavernet wants to merge 1 commit into
ParadevAI:mainfrom
Joaco-gavernet:codex-model-discovery-11b2031e

Conversation

@Joaco-gavernet

@Joaco-gavernet Joaco-gavernet commented Nov 1, 2026 •

Copy link
Copy Markdown

What & why

Codex's fixed model list can miss models offered by the installed CLI. Discover the catalog through Codex app-server after its initialization handshake, read all model/list pages with includeHidden: true, and derive model identifiers and reasoning options from the returned metadata.

Add Settings → Agent commands → Codex controls for which models appear in the desktop picker. Save those choices separately from provider-hidden flags, preserve catalog ordering, and keep a valid effective selection when a model disappears or the active choice is deselected. Reuse the existing Codex executable, launch environment, authentication, RPC transport, and preference storage conventions; remove the manually maintained Codex catalog.

Mobile consumes the same discovery endpoint with its existing launch preferences. Desktop visibility preferences remain local to the desktop. The installed Codex ACP adapter rejects provider-hidden models, so chat pickers exclude those models while terminal pickers can include them.

Context: Discord model picker discussion.

Attribution

The Codex model discovery integration was adapted from Kiet Ho's existing commit 40241abb73079feab41ae27a79d3ea075ae94b70 — feat(agents): read Codex's model list from the installed CLI.

This PR builds on that discovery work with persisted desktop picker selections, provider-hidden metadata handling, reasoning defaults, and related UI and launch validation. Credit for the original discovery implementation belongs to Kiet Ho; it is not claimed as entirely new work by this PR's author.

How I tested it

  • bun run lint and bun run typecheck passed.
  • bun run check:i18n passed strict compilation for all 18 locales.
  • bun run test --filter=!@superset/agent-setup passed all 29 tasks, including 9,059 desktop tests and 2,711 host-service tests.
  • After the final cleanup, focused shared/discovery tests passed: 93 tests, 426 assertions.
  • Real desktop UI: discovered 11 Codex models; changed selections; checked ordering; restarted the app and confirmed persistence; checked last-choice protection and active-model recovery. Actual Codex process arguments included the selected model and catalog default reasoning effort. A real Codex chat returned the requested proof response.
  • Controlled app-server catalogs through the real Settings/host path: pagination, errors, empty results, recovery, account-environment changes, disappearing models, and preservation of saved preferences.
  • Verified the same saved hidden-model preference appears in the terminal picker and is excluded from the chat picker.

The standard bun run test command is not green: two shell-wrapper tests in @superset/agent-setup also fail from clean HEAD on this Mac because login-shell PATH ordering invokes the installed Claude binary instead of the test binary. The excluded-package run above does not replace that standard check.

Screenshots

Codex model selection in Settings

Filtered Codex model picker

Screenshots live on a separate evidence branch in the fork and are not part of this PR's code diff.

Remaining before ready for review

  • Resolve the old-host update guard and coordinated minimum host version for the new agents.listModels endpoint. Existing remote hosts may not expose it.
  • Native mobile UI remains unverified; the available mobile account lacks Pro access.
  • Real cloud provisioning remains unverified: the isolated sandbox attempt was rejected with HTTP 403 before creating any resources. The branch host-service bundle built locally, but no release or bundle was published.
  • No second physical host was exercised. Account-environment edge cases used controlled catalogs, not two real account entitlements.
  • A returned catalog can be bundled or cached and does not establish inference entitlement for every model.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on this fork PR
  • I have signed the CLA (the bot asks on the first PR)

Draft for contributor walkthrough and maintainer discussion; the unresolved items above are not claimed complete.


Summary by cubic

Replaces the hand-maintained Codex model catalog with one discovered from the installed CLI and lets desktop users choose which models the picker shows.

New Features

  • Discovers models through the Codex app-server handshake after initialization, paginates model/list with includeHidden: true, and caches the catalog per account on the host service.
  • Adds Settings → Agent commands → Codex controls; desktop saves visibility locally, separate from provider-hidden flags, preserves catalog ordering, and keeps a valid active selection when a model disappears or gets deselected.
  • Chat pickers exclude provider-hidden models while terminal pickers can list them; mobile uses the same discovery endpoint with its existing launch preferences.
  • Host launch validation accepts models present only in the live catalog, and the manually maintained Codex list is removed.

Migration

  • Existing remote hosts must expose the new agents.listModels endpoint; the coordinated minimum host version and old-host update guard are not yet resolved.

Written for commit 992fea0. Summary will update on new commits.

View guided diff

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Joaco-gavernet

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Nov 1, 2026
Kitenite added a commit that referenced this pull request Nov 8, 2026
* chore: seed CLA signature file

* @tanxarx has signed the CLA in #8881

* @ozeitis has signed the CLA in #8888

* @shubhankiit has signed the CLA in #8894

* @chrisfentiman has signed the CLA in #8910

* @RohithReddy20 has signed the CLA in #8907

* @larcane97 has signed the CLA in #8922

* @moizghumann has signed the CLA in #8935

* @andyst-dev has signed the CLA in #7930

* @svenpeeters has signed the CLA in #8943

* @kenil-kanani has signed the CLA in #8940

* @akshatcoder-hash has signed the CLA in #8963

* @NilotpalK has signed the CLA in #8995

* @serhii-kucherenko has signed the CLA in #9000

* @tonydzi has signed the CLA in #9002

* @adaam2 has signed the CLA in #9038

* @tsavo-at-pieces has signed the CLA in #9059

* @ganeshmshetty has signed the CLA in #9130

* @aaronrosenthal has signed the CLA in #9135

* @alexnault has signed the CLA in #9138

* @kunalgoesbyken has signed the CLA in #9235

* @Joaco-gavernet has signed the CLA in #9236

* @theblondealex has signed the CLA in #8240

* @talarczykco has signed the CLA in #7274

* @throw99 has signed the CLA in #7906

* @lacherogwu has signed the CLA in #9310

* @KGKallasmaa has signed the CLA in #9316

* @Niltonsf has signed the CLA in #9331

* @Anmol1578 has signed the CLA in #9351

* @RyoKusnadi has signed the CLA in #9317

* @thedotmack has signed the CLA in #9414

* @abudker has signed the CLA in #9439

* @sanchitmonga22 has signed the CLA in #9443

* @Bruno-rose has signed the CLA in #9446

* @Ashad001 has signed the CLA in #9487

* @vivek-pothina has signed the CLA in #8359

* @colingreig has signed the CLA in #9489

* @anmol0b has signed the CLA in #9492

* @resteqs has signed the CLA in #9506

* @pgilmore has signed the CLA in #7878

* fix(desktop): name the DMG from the display name

The DMG file and its volume title now use DESKTOP_DISPLAY_NAME, so a
Paradev build ships Paradev-<version>-<arch>.dmg. Unset, names stay
Superset. The release keeps the Superset-<arch>.dmg alias beside the new
one, since the README, docs and download button link to it. The .app
bundle and the -mac.zip update files keep the Superset name.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant