Repository navigation
feat(desktop): discover Codex models and configure picker visibility - #9236
Draft
Joaco-gavernet wants to merge 1 commit into
Draft
Joaco-gavernet wants to merge 1 commit into
Joaco-gavernet wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Kitenite
added a commit
that referenced
this pull request
Nov 8, 2026
* chore: seed CLA signature file * @tanxarx has signed the CLA in #8881 * @ozeitis has signed the CLA in #8888 * @shubhankiit has signed the CLA in #8894 * @chrisfentiman has signed the CLA in #8910 * @RohithReddy20 has signed the CLA in #8907 * @larcane97 has signed the CLA in #8922 * @moizghumann has signed the CLA in #8935 * @andyst-dev has signed the CLA in #7930 * @svenpeeters has signed the CLA in #8943 * @kenil-kanani has signed the CLA in #8940 * @akshatcoder-hash has signed the CLA in #8963 * @NilotpalK has signed the CLA in #8995 * @serhii-kucherenko has signed the CLA in #9000 * @tonydzi has signed the CLA in #9002 * @adaam2 has signed the CLA in #9038 * @tsavo-at-pieces has signed the CLA in #9059 * @ganeshmshetty has signed the CLA in #9130 * @aaronrosenthal has signed the CLA in #9135 * @alexnault has signed the CLA in #9138 * @kunalgoesbyken has signed the CLA in #9235 * @Joaco-gavernet has signed the CLA in #9236 * @theblondealex has signed the CLA in #8240 * @talarczykco has signed the CLA in #7274 * @throw99 has signed the CLA in #7906 * @lacherogwu has signed the CLA in #9310 * @KGKallasmaa has signed the CLA in #9316 * @Niltonsf has signed the CLA in #9331 * @Anmol1578 has signed the CLA in #9351 * @RyoKusnadi has signed the CLA in #9317 * @thedotmack has signed the CLA in #9414 * @abudker has signed the CLA in #9439 * @sanchitmonga22 has signed the CLA in #9443 * @Bruno-rose has signed the CLA in #9446 * @Ashad001 has signed the CLA in #9487 * @vivek-pothina has signed the CLA in #8359 * @colingreig has signed the CLA in #9489 * @anmol0b has signed the CLA in #9492 * @resteqs has signed the CLA in #9506 * @pgilmore has signed the CLA in #7878 * fix(desktop): name the DMG from the display name The DMG file and its volume title now use DESKTOP_DISPLAY_NAME, so a Paradev build ships Paradev-<version>-<arch>.dmg. Unset, names stay Superset. The release keeps the Superset-<arch>.dmg alias beside the new one, since the README, docs and download button link to it. The .app bundle and the -mac.zip update files keep the Superset name. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Codex's fixed model list can miss models offered by the installed CLI. Discover the catalog through Codex
app-serverafter its initialization handshake, read allmodel/listpages withincludeHidden: true, and derive model identifiers and reasoning options from the returned metadata.Add Settings → Agent commands → Codex controls for which models appear in the desktop picker. Save those choices separately from provider-hidden flags, preserve catalog ordering, and keep a valid effective selection when a model disappears or the active choice is deselected. Reuse the existing Codex executable, launch environment, authentication, RPC transport, and preference storage conventions; remove the manually maintained Codex catalog.
Mobile consumes the same discovery endpoint with its existing launch preferences. Desktop visibility preferences remain local to the desktop. The installed Codex ACP adapter rejects provider-hidden models, so chat pickers exclude those models while terminal pickers can include them.
Context: Discord model picker discussion.
Attribution
The Codex model discovery integration was adapted from Kiet Ho's existing commit 40241abb73079feab41ae27a79d3ea075ae94b70 — feat(agents): read Codex's model list from the installed CLI.
This PR builds on that discovery work with persisted desktop picker selections, provider-hidden metadata handling, reasoning defaults, and related UI and launch validation. Credit for the original discovery implementation belongs to Kiet Ho; it is not claimed as entirely new work by this PR's author.
How I tested it
bun run lintandbun run typecheckpassed.bun run check:i18npassed strict compilation for all 18 locales.bun run test --filter=!@superset/agent-setuppassed all 29 tasks, including 9,059 desktop tests and 2,711 host-service tests.The standard
bun run testcommand is not green: two shell-wrapper tests in@superset/agent-setupalso fail from clean HEAD on this Mac because login-shell PATH ordering invokes the installed Claude binary instead of the test binary. The excluded-package run above does not replace that standard check.Screenshots
Screenshots live on a separate evidence branch in the fork and are not part of this PR's code diff.
Remaining before ready for review
agents.listModelsendpoint. Existing remote hosts may not expose it.Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)Draft for contributor walkthrough and maintainer discussion; the unresolved items above are not claimed complete.
Summary by cubic
Replaces the hand-maintained Codex model catalog with one discovered from the installed CLI and lets desktop users choose which models the picker shows.
New Features
app-serverhandshake after initialization, paginatesmodel/listwithincludeHidden: true, and caches the catalog per account on the host service.Migration
agents.listModelsendpoint; the coordinated minimum host version and old-host update guard are not yet resolved.Written for commit 992fea0. Summary will update on new commits.