Repository navigation
fix(cloud): --effort and --tag take effect for cloud workspaces (SUPER-3306) #9638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,6 +65,9 @@ export function normalizeWorkspaceTags( | |
| return [...unique].sort(); | ||
| } | ||
|
|
||
| // biome-ignore lint/suspicious/noControlCharactersInRegex: matching them is the point. | ||
| const CONTROL_CHARACTER = /[\u0000-\u001f\u007f]/; | ||
|
|
||
| /** Router-boundary schema for one tag; parses to its stored normalized form. */ | ||
| export const workspaceTagInputSchema = z | ||
| .string() | ||
|
|
@@ -75,6 +78,12 @@ export const workspaceTagInputSchema = z | |
| message: `Tag must be 1-${WORKSPACE_TAG_MAX_LENGTH} characters after trimming`, | ||
| }); | ||
| } | ||
| if (CONTROL_CHARACTER.test(tag)) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ctx.addIssue({ | ||
| code: "custom", | ||
| message: "Tag must not contain control characters", | ||
| }); | ||
| } | ||
| }) | ||
| .transform((tag) => normalizeWorkspaceTag(tag) as string); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: ParadevAI/Paradev
Length of output: 46594
Script executed:
Repository: ParadevAI/Paradev
Length of output: 20882
Script executed:
Repository: ParadevAI/Paradev
Length of output: 38657
Script executed:
Repository: ParadevAI/Paradev
Length of output: 14591
Script executed:
Repository: ParadevAI/Paradev
Length of output: 4218
Require an effort-capable sandbox for chat launches.
An older sandbox can launch the chat without the requested effort. Ensure the sandbox bundle supports effort before using chat for an effort request, or fall back to a supported launch.
Raise
MIN_HOST_SERVICE_VERSIONand document why the newer host is required. The version floor alone does not guard provisioning.Source: Coding guidelines