Repository navigation
fix(desktop): register daemon sessions with port manager on startup - #964
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe change adds session registration logic during startup reconciliation, iterating through preserved sessions and invoking Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Port scanning was not working for terminals that were already running after an app restart or update. The issue was that reconcileOnStartup() cached session IDs but did not register them with the port manager. Port scanning only started working after the user manually opened each terminal tab, which triggered createOrAttach() to call upsertDaemonSession(). Now preserved daemon sessions are registered with the port manager during startup reconciliation, enabling immediate port detection.
1412c66 to
2981edc
Compare
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
reconcileOnStartup()Test plan
bun dev)Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.