Repository navigation
Prepare gated domain cutover and final deployment artifacts - #9702
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
|
Preview update published for development build |
|
Verdict: needs changes. The gate moves the OAuth-provider login page to the new host, which breaks this PR's own "OAuth/CLI/MCP stay on the old host" contract. The rest is careful and well tested.
Tests at Full review: https://app.superset.sh/page/pr-9702-review-domain-cutover-prep-nubjin |
Moving browser sign-in onto paradev.com needs reversible redirects that preserve released clients and in-flight auth and billing returns. This PR prepares fixed-origin 307s behind default-disabled
DOMAIN_MOVE_ENABLEDand the sharedweb-domain-moveflag. Web and desktop use the same browser cohort; API/tRPC, CLI/MCP/OAuth, desktop callbacks, invitations and billing returns stay on their existing host. Signed OAuth login/signup continuations remain on the legacy host without evaluating the rollout flag.The manual staging workflow gains
prepare-final: build only the two new projects with final browser URLs and the legacy token issuer, use--skip-domain, and report artifacts without assigning aliases. Production workflow wiring remains deferred; deploy-production.yml is unchanged. The mocked deployment guard suite now runs in CI.Sentry currently has one configured Redirect URL on api.superset.sh. Final/stage Sentry connect hands off to a fixed legacy-web continuation before OAuth state creation, signs in there if necessary, and resumes at the old API with the explicit organization ID. The original API membership check still authorizes the organization before state is created. The continuation, Sentry result page and protected sign-in continuations remain on the old host even at 100% rollout.
Validation before merge: focused suites, 5 Python workflow guard tests, API/web/shared typechecks, Biome, actionlint and independent review passed. The latest head
20dc47c051f87ecc0f4b3e313ad434c7c86a2aa6passed CI, including tests, typechecks, lint, CLI build and deployment previews. CodeRabbit passed; Cubic was neutral because of its monthly review quota.Final-domain acceptance — November 13, 2026
Merged by explicit admin authorization as
2eda1fefa86c665999fe82a2c08a368002acb63f. Production deployment and prepare-final succeeded.The final domains now belong to the new Vercel projects and point to artifacts built from that merge:
dpl_4hLmc3YPFi9X2wNMct2Zk5PhxKd4dpl_GYWRkG7Zgt7d13HobEufYLaouDJQVerified with real browser flows and deployed endpoints:
$identifywith that exact$anon_distinct_idand the account ID. All resolve to one person. This used an existing designated test account, not a newly created signup.Rollout remains off: marketing still links to app.superset.sh, old-web and legacy desktop-start redirects are not enabled, and the rollout flag was not changed. Only the existing app.paradev.com platform redirect was removed as part of assigning that final domain.
Limits before broader rollout: actual integration consent/install writes were not exercised. Teams/Notion registrations remain unverified; only Sentry has the legacy handoff implemented here. GitHub passed on staging but was not rerun on the final domain in this acceptance pass. Installed desktop sessions were not replaced.
Summary by CodeRabbit