Repository navigation
feat(desktop): add command menu (⌘P) - #976
saddlepaddle wants to merge 1 commit into
Conversation
- Add CommandMenu component with context-aware commands - Show workspace-specific actions when in a workspace - Display workspace hotkeys (⌘1-9) in the workspace list - Add navigation commands for settings pages - Include actions like new workspace, change theme, toggle sidebar - Co-locate CommandMenu with dashboard layout
📝 WalkthroughWalkthroughThe PR introduces a Command Menu system for the desktop application, featuring a command palette that integrates with workspaces and contextual commands. It adds keyboard shortcut triggering (meta+p), context-aware command grouping, and command execution handlers with workspace switching, tab management, theme control, and navigation support. Changes
Sequence DiagramsequenceDiagram
participant User
participant Dashboard as Dashboard Layout
participant CommandMenu
participant useCommandContext
participant electronTrpc
participant useCommandActions
participant Store as Workspace/<br/>Theme Stores
User->>Dashboard: Press meta+p
Dashboard->>CommandMenu: isCommandMenuOpen = true
CommandMenu->>useCommandContext: Request workspace context
useCommandContext->>electronTrpc: Fetch workspace data
electronTrpc-->>useCommandContext: Workspace details
useCommandContext-->>CommandMenu: CommandContext (workspaceId, name, branch, etc.)
CommandMenu->>CommandMenu: Build command groups<br/>(contextual, workspaces, actions, navigation)
CommandMenu->>User: Display command palette
User->>CommandMenu: Select command
CommandMenu->>useCommandActions: executeCommand(commandId)
alt Workspace Switch Command
useCommandActions->>Store: Switch active workspace
else Settings/Theme Command
useCommandActions->>Store: Update theme or navigate
else Navigation Command
useCommandActions->>Dashboard: Navigate to settings/external
end
useCommandActions->>Dashboard: closeMenu()
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly Related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing: stale command menu PR from Jan 26. Quick Open / command palette has evolved since (see #2291). |
|
Hey — just a heads up, this was closed as part of an automated stale PR cleanup. If you think this was done in error, feel free to reopen it! |
|
Hey — this was closed by an automated cleanup of PRs with major merge conflicts that are 3+ weeks old. If you think this was done incorrectly, please feel free to reopen it. Sorry for any inconvenience! |
Summary
⌘P) to desktop app for quick access to commands and navigationFeatures
Test plan
⌘Pto open command menuSummary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.