Remove 'mesh' arg from add_constant_field - #2880
Merged
VeckoTheGecko merged 2 commits intoSep 3, 2026
Merged
Conversation
| raise ValueError(f"mesh must be one of ['flat', 'spherical']. Got {mesh!r}.") | ||
|
|
||
| if self.constant_model is None: | ||
| mesh = "flat" if isinstance(self.mesh, FlatMesh) else self.mesh |
Member
There was a problem hiding this comment.
Why can't mesh be FlatMesh here? Why does it need to be a string only for flat meshes, and an object otherwise?
Contributor
Author
There was a problem hiding this comment.
Since within create_empty_constant_field_model, from_sgrid_conventions expects mesh: Literal['flat', spherical'] | SphericalMesh (FlatMesh is not part out our public API, and is instead created internally from the "flat" keyword).
I have moved this cast statement to be in create_empty_constant_field_model now so its closer to the part that needs it
VeckoTheGecko
force-pushed
the
add-constant-field
branch
from
September 3, 2026 06:16
6feb027 to
ed03bef
Compare
erikvansebille
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we have
fieldset.meshin #2848, we no longer need this argument.Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None used