Skip to content

Support Follow Through cluster jewel notable - #10327

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/follow-through-capped-damage
Open

Support Follow Through cluster jewel notable#10327
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/follow-through-capped-damage

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes #10172

Description of the problem being solved:

  • Follow-Through’s current “up to a maximum of 100%” wording was only partially parsed, causing PoB to discard the entire modifier. The up to 100% wording parsed but incorrectly excluded ailments.
  • This adds explicit parser rules for both capped wordings, applying the bonus to projectile hits and ailments while enforcing the shared 100% increased-damage cap across allocated notables.

Steps taken to verify a working solution:

  • Load test build
  • Compare damage values
  • Ensure that stacking multiple jewels works and that changing number of chains in configs updates damage as expected
  • Ensure that poison works as a sample ailment
  • Ensure that Arc doesn't get a bonus since it's not a projectile skill

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-Through

1 participant