Skip to content

Do not set wrong (character based) content-length in AutoPage handler - #1139

Closed
pepl wants to merge 1 commit into
PerlDancer:masterfrom
pepl:master
Closed

pepl wants to merge 1 commit into
PerlDancer:masterfrom
pepl:master

Conversation

@pepl

@pepl pepl commented Mar 8, 2016

Copy link
Copy Markdown

Also added tests for correct content-length headers setting in case of non-ASCII output

…rrect content-length headers in case of non-ASCII output
@veryrusty

Copy link
Copy Markdown
Member

👍

@veryrusty

Copy link
Copy Markdown
Member

@pepl++ Thanks for the PR. Always happy to see new contributors to Dancer2!
Merged as 6bdc104. 👯

ps. the PR was missing a change to t/views/auto_page.tt to include the ö character, and I also tweaked the test case to explicitly match the encoded bytes for a ö character.

@veryrusty veryrusty closed this Mar 9, 2016
xsawyerx added a commit that referenced this pull request Apr 19, 2016
    [ BUG FIXES ]
    * GH #1102: Handle multiple '..' in file path utilities.
      (Oleg A. Mamontov, Peter Mottram)
    * GH #1114: Fix missing prereqs as reported by CPANTS.
      (Mohammad S Anwar)
    * GH #1128: Shh warning if optional megasplat is not present.
      (David Precious)
    * GH #1139: Fix incorrect Content-Length header added by AutoPage
      handler (Michael Kröll, Russell Jenkins)
    * GH #1144: Change tt tags to span in skel (Jason Lewis)
    * GH #1046: "no_server_tokens" configuration option doesn't work.
      (Sawyer X)
    # GH #1155, #1157: Fix megasplat value splitting when there are empty
      trailing path segments. (Tatsuhiko Miyagawa, Russell Jenkins)
      NOTE: Paths matching a megasplat that end with a '/' will now include
      an empty string as the last value. For the route pattern '/foo/**',
      the path '/foo/bar', the megasplat gives ['bar'], whereas '/foo/bar/'
      now gives ['bar','']. Joining the array of megasplat values will now
      always be the string matched against for the megasplit.

    [ DOCUMENTATION ]
    * GH #1119: Improve the deployment documentation. (Andrew Beverley)
    * GH #1123: Document import of utf8 pragma. (Victor Adam)
    * GH #1132: Fix spelling mistakes in POD (Gregor Herrmann)
    * GH #1134: Fix spelling errors detected by codespell (James McCoy)
    * GH #1153: Fix POD rendering error. (Sawyer X)

    [ ENHANCEMENTS ]
    * GH #1129: engine.logger.* hooks are called around logging a message.
      (Russell @veryrusty Jenkins)
    * GH #1146: Cleaner display of error context (Vernon Lyon)
    * GH #1085: Add consistent keywords for accessing headers;
      'request_header' for request, 'response_header', 'response_headers'
      and 'push_response_header' for response. (Russell @veryrusty Jenkins)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants