Repository navigation
fix(http): align IncomingMessage headers and encoding - #3525
Merged
proggeramlug merged 5 commits intoMay 31, 2026
Merged
proggeramlug merged 5 commits into
proggeramlug merged 5 commits into
Conversation
This was referenced May 31, 2026
added 4 commits
May 31, 2026 17:54
# Conflicts: # crates/perry-ext-http/src/lib.rs # crates/perry-stdlib/src/common/mod.rs # crates/perry-stdlib/src/http.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3272
Closes #3273
Closes #3416
Summary
IncomingMessage.headersfor statically tagged request handlers.datachunks asBufferobjects by default soBuffer.concat()works.IncomingMessage.setEncoding()for client responses and server request handles, switching futuredatachunks to decoded strings.Why Batched
These issues all cover the
node:httpIncomingMessagerequest/response stream surface and share the same stdlib/runtime dispatch paths, so one patch avoids duplicating fixture setup and handle-routing changes.Tests Added
test-parity/node-suite/http/incoming-message/client-set-encoding.tstest-parity/node-suite/http/incoming-message/server-headers-body.tsVerification
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module httpfailed the newincoming-messagefixtures as expected; reporttest-parity/reports/parity_report_20260531_042106.json.PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module http/incoming-messagepassed 2/2; reporttest-parity/reports/parity_report_20260531_050116.json.PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module httppassed 9/10 with only the existingnode-suite/http/server/upgrade-websocketoutput mismatch remaining; reporttest-parity/reports/parity_report_20260531_050245.json.RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-hir -p perry-api-manifest -p perry -p perry-stdlib -p perry-ext-http -p perry-ext-http-serverpassed with existing warnings.cargo fmt --all -- --checkpassed../scripts/check_file_size.shpassed.jq empty test-parity/known_failures.jsonpassed.git diff --checkpassed.Non-Goals
rawHeadersoriginal casing preservation.Bufferbody writes.http/server/upgrade-websocketparity output mismatch.IncomingMessagemetadata/timeout surface tracked separately.