Repository navigation
test(buffer): lock Uint8Array.prototype.buffer ArrayBuffer return type (#3961) - #4048
Merged
Merged
Conversation
added 2 commits
June 2, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3961.
Uint8Array.prototype.bufferandUint8Array.prototype.slice().buffernow return a realArrayBufferinstead of theUint8Array/Bufferitself. The substantive runtime fix landed onmainin #4041 (runtime/binary-data: complete ArrayBuffer/DataView view semantics); this PR adds a byte-for-byte parity regression test so the behaviour stays locked.Verified against Node v25 — identical output:
The test asserts the ArrayBuffer identity semantically (
instanceof,Object.prototype.toString.call,byteLength, byte round-trip) rather than dumping the rawconsole.log(buffer)representation: Node renders a 9-byteArrayBuffer(and theUint8Array(9)line) across multiple lines via itsbreakLength/number-grouping inspect rules, which is a separate, general console-formatting parity gap unrelated to the return-type bug this issue reports.Test plan
test-parity/node-suite/buffer/properties/uint8array-buffer-getter.tsmatches Node byte-for-byte.