Repository navigation
[codex] honor child_process timeout killSignal - #4262
Merged
proggeramlug merged 1 commit intoJun 4, 2026
Merged
proggeramlug merged 1 commit into
proggeramlug merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
options.killSignalwhen timeout kills bufferedexec()/execFile()and syncspawnSync()/execSync()/execFileSync()childrenspawn()/fork()timeout termination through the child-process reactor soexit/close,killed, andsignalCodereflect the configured signalChildProcess#kill()and timeout pathsSIGKILLScope
Refs #2555 and #2130. This is the deterministic timeout/killSignal child_process option slice only.
Non-goals
AbortSignal lifecycle semantics, numeric fd sharing, custom stream handles, uid/gid, detached/platform flags, and broad child_process option validation remain follow-up work.
Validation
npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/child_process/async/timeout-killsignal.tsCARGO_TARGET_DIR=/tmp/perry-child-timeout-check cargo check -p perry-runtimePERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/tmp/perry-node-child-process-timeout-killsignal npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process --filter timeout-killsignal & pid=$!; while kill -0 "$pid" 2>/dev/null; do echo "[heartbeat] child_process timeout parity still running"; sleep 20; done; wait "$pid"'/root/perry-worktrees/perry-node-child-process-timeout-killsignal/test-parity/reports/parity_report_20260603_142824.jsonPERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/tmp/perry-node-child-process-timeout-killsignal npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process & pid=$!; while kill -0 "$pid" 2>/dev/null; do echo "[heartbeat] child_process full parity still running"; sleep 20; done; wait "$pid"'/root/perry-worktrees/perry-node-child-process-timeout-killsignal/test-parity/reports/parity_report_20260603_142901.jsoncargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh