Repository navigation
[codex] fix runtime async generator request queue - #4492
Merged
proggeramlug merged 2 commits intoJun 5, 2026
Merged
Conversation
proggeramlug
marked this pull request as ready for review
June 5, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next/return/throwmethods with a runtime request queue.thenslotsRoot Cause
Lowered async generator instance methods could be invoked reentrantly without Node-compatible request queue semantics. That let same-stack
next()calls race the in-flight request instead of being serialized behind it.Fixes #4438
Validation
cargo check -q -p perry-runtime --libcargo build --release -p perry-runtime -p perrywithCARGO_TARGET_DIR=/root/perry-worktrees/perry-node-probe-20260604/target CARGO_BUILD_JOBS=1cargo fmt --all -- --checkgit diff --checkandgit diff --cached --check./scripts/check_file_size.shcargo test -q -p perry-runtime test_gc_init_mutable_scanner_families_rewrite_runtime_slotswith sharedCARGO_TARGET_DIRasync-generator-request-queue.ts, generator intrinsic/prototype fixtures,stream/readable/from-async-iterable.ts, and Promise queue fixtures