Repository navigation
fix(globals): expose legacy escape and global alias - #4545
Merged
proggeramlug merged 2 commits intoJun 7, 2026
Merged
proggeramlug merged 2 commits into
proggeramlug merged 2 commits into
Conversation
proggeramlug
force-pushed
the
codex/node-compat-globals-escape-global-20260605
branch
from
June 7, 2026 14:15
ba171a0 to
8ab7a01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
globalself-reference onglobalThisand recognize bareglobalreadsescape/unescapeas callable global functions with Node-compatible descriptors, names, lengths, coercion, and Symbol errors%uXXXXbehavior, and Symbol TypeErrorsFixes #4511.
Validation:
cargo fmt --all -- --checkgit diff --check origin/main..HEAD./scripts/check_file_size.shjq empty test-parity/known_failures.jsonenv RUSTC_WRAPPER= TMPDIR=$PWD/target/tmp CARGO_BUILD_JOBS=1 cargo check -q -p perry-runtime -p perry-hir -p perry-codegenenv RUSTC_WRAPPER= TMPDIR=$PWD/target/tmp CARGO_BUILD_JOBS=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module globals --filter legacy-escape-global'(1 pass / 0 parity fail / 0 compile fail, reporttest-parity/reports/parity_report_20260605_075255.json)env RUSTC_WRAPPER= TMPDIR=$PWD/target/tmp CARGO_BUILD_JOBS=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module globals --filter global-functions'(1 pass / 0 parity fail / 0 compile fail, reporttest-parity/reports/parity_report_20260605_075512.json)env RUSTC_WRAPPER= TMPDIR=$PWD/target/tmp CARGO_BUILD_JOBS=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module globals'(86 pass / 0 parity fail / 0 compile fail / 0 skipped, reporttest-parity/reports/parity_report_20260605_075659.json)