Skip to content

fix(runtime): Number.isInteger/isSafeInteger usable as first-class function values #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jun 5, 2026
Merged

fix(runtime): Number.isInteger/isSafeInteger usable as first-class function values #4631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crates/perry-hir/src/lower/expr_member.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,10 +1850,17 @@ fn lower_member_inner(ctx: &mut LoweringContext, member: &ast::MemberExpr) -> Re
// undefined). `Array.fromAsync` is unreified and stays
// undefined either way. Direct calls keep the intrinsic
// fast path via the `!member_is_call_callee` gate.
// #4627: all six Number statics (isFinite / isInteger /
// isNaN / isSafeInteger / parseFloat / parseInt) are reified
// with metadata via install_constructor_static, so routing
// value reads to the reified Number receiver is safe and
// fixes the missing `.name`/`.length` on isInteger /
// isSafeInteger. (String's fromCharCode/etc. are NOT reified
// yet — left to #4627.)
let outer_is_reified_builtin_static_value = !member_is_call_callee
&& matches!(
property.as_str(),
"JSON" | "Reflect" | "BigInt" | "Symbol" | "Array"
"JSON" | "Reflect" | "BigInt" | "Symbol" | "Array" | "Number"
)
&& outer_static_member
.map(|member| {
Expand Down