Skip to content

fix(runtime): <canonical index string> in <Uint8Array>/Buffer returns true (#6148 follow-up) #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proggeramlug wants to merge 1 commit into from
Closed

fix(runtime): <canonical index string> in <Uint8Array>/Buffer returns true (#6148 follow-up) #6168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/perry-runtime/src/object/field_get_set/has_property.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,15 @@ pub extern "C" fn js_object_has_property(obj: f64, key: f64) -> f64 {
) {
return nanbox_true;
}
// A canonical numeric-index string (`"0"`, `"2"`, …) is an own
// in-bounds index. The round-trip check rejects non-canonical
// forms (`"00"`, `"1.5"`, `"-1"`, `"0x1"`), which are ordinary
// (absent) string keys.
if let Ok(idx) = name.parse::<u32>() {
if idx.to_string() == name && idx < len as u32 {
return nanbox_true;
}
}
}
return nanbox_false;
}
Expand Down
Loading