Repository navigation
[Minor] Fix desync caused by units with DeploysInto - #1525
Merged
CrimRecya merged 5 commits intoApr 11, 2025
Merged
Conversation
github-actions
Bot
added
the
Minor
CrimRecya
added
Needs testing
Minor
CrimRecya
changed the title
DeployIntoDeploysInto
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
CrimRecya
changed the title
DeploysIntoDeploysInto
Coronia
added
❓Crash / Desync
❓Phobos bug
DeathFishAtEase
force-pushed
the
develop
branch
from
February 28, 2025 16:36
2128644 to
799ea22
Compare
Contributor
|
think this PR should still be addressed before a real 0.4 release. We'd better come up with a decision of whether current implementation should be adjusted sooner |
Member
You should add credits for that :P |
Metadorius
approved these changes
Apr 10, 2025
Coronia
pushed a commit
that referenced
this pull request
Apr 12, 2025
Game removes deploying vehicles from map temporarily to check if there's enough space to deploy into a building when displaying allow/disallow deploy cursor. This can cause desyncs if there are certain types of units around the deploying unit because the OccupationFlags may be accidentally cleared, or the order of the objects linked list may be scrambled. About implementation: This is a hook separated from #1479 . This solution completely abandons the method of removing and then adding, and solves the problem by directly excluding specific units. Other related repairs: Fix unit's self-destruct when using trigger 107 to teleport the MCV. Fix reconnection error when moving MCV with Teleport locomotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game removes deploying vehicles from map temporarily to check if there's enough space to deploy into a building when displaying allow/disallow deploy cursor. This can cause desyncs if there are certain types of units around the deploying unit because the OccupationFlags may be accidentally cleared, or the order of the objects linked list may be scrambled.
About implementation:
This is a hook separated from #1479 .
This solution completely abandons the method of removing and then adding, and solves the problem by directly excluding specific units.
Other related repairs:
Fix unit's self-destruct when using trigger 107 to teleport the MCV.
Fix reconnection error when moving MCV with Teleport locomotion.