Skip to content

fix(codex): bundle the native codex binary in the packaged app#3188

Merged
joshsny merged 1 commit into
mainfrom
fix/bundle-native-codex
Jul 6, 2026
Merged

fix(codex): bundle the native codex binary in the packaged app#3188
joshsny merged 1 commit into
mainfrom
fix/bundle-native-codex

Conversation

@joshsny

@joshsny joshsny commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The app-server harness resolves the native codex CLI as a sibling of the
bundled codex-acp binary, but packaging only staged codex-acp and rg — so
production always logged nativeBinaryFound:false and silently fell back to
codex-acp even with the codex-app-server flag on. Stage the binary and make
the release verifier assert it (and rg) exist file-level.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

The app-server harness resolves the native codex CLI as a sibling of the
bundled codex-acp binary, but packaging only staged codex-acp and rg — so
production always logged nativeBinaryFound:false and silently fell back to
codex-acp even with the codex-app-server flag on. Stage the binary and make
the release verifier assert it (and rg) exist file-level.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@joshsny
joshsny enabled auto-merge (squash) July 6, 2026 15:38
@joshsny
joshsny requested a review from a team July 6, 2026 15:38
@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(codex): bundle the native codex bina..." | Re-trigger Greptile

@joshsny
joshsny merged commit bc190a5 into main Jul 6, 2026
20 checks passed
@joshsny
joshsny deleted the fix/bundle-native-codex branch July 6, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants